go-tuf icon indicating copy to clipboard operation
go-tuf copied to clipboard

Make repository.repositoryType public (repository.RepositoryType)

Open eikenb opened this issue 1 year ago • 2 comments

The library uses repository.repositoryType as a way to manage the role metadata and interact with it while using the library. However the type is private and so cannot be used in any abstractions where you'd want to pass it as an argument.

Please consider making this type public so it can be used in abstractions.

Thanks.

eikenb avatar Oct 10 '24 22:10 eikenb

hey, @eikenb, thanks for reaching out 🙏

Do you have a specific use case for using this type? I'm asking this because so far it has been used only in the examples and we were discussing moving this package there to simplify things. We can make it public of course while doing this.

rdimitrov avatar Oct 15 '24 13:10 rdimitrov

Moving the package to the examples area would be a great idea.

Right now, when working off the examples to help understand the package, using this type initially looks like a nice way to work with the roles as a group, when in fact it isn't, and that confuses things.

eikenb avatar Oct 21 '24 18:10 eikenb

Opened a PR to make the move 👍

rdimitrov avatar Oct 30 '24 09:10 rdimitrov