go-tuf icon indicating copy to clipboard operation
go-tuf copied to clipboard

Remove `keyid_hash_algorithms`

Open znewman01 opened this issue 2 years ago • 1 comments

go-tuf added keyid_hash_algorithms as a field in 2fbbd60 (June 2020); see python-tuf#848 for context. However, it never made it into the spec, and now it’s not needed due to TAP-12 (which is accepted). python-tuf removed it (python-tuf#1014); we should too.

znewman01 avatar Sep 01 '22 14:09 znewman01

@trishankatdatadog brings up a good point: be careful about backwards compat here! Old clients may expect this field.

So we should:

  • stop expecting it (client side) immediately
  • after a minor version bump, stop producing it (repo side) for new repos
  • have an option to keep producing it indefinitely, if a repo ever had it (they probably don't want to break old clients)

znewman01 avatar Sep 01 '22 15:09 znewman01

Closing since the code base changed and this is already fixed.

Thanks for raising this 👍

rdimitrov avatar Jan 31 '24 21:01 rdimitrov