Cory Fields
Cory Fields
1. It didn't actually disable asm usage in our code. Regardless of the setting, asm is used in random.cpp and support/cleanse.cpp. 2. The value wasn't forwarded to libsecp as a...
This was missed in 31ba40494428dcbf2eb5eb6f2328eca91b0b0746 because older versions of clang did not complain about it. But clang-17, at least, does. The array-as-a-param makes this annoying because `sizeof(l)` is not helpful....
At the moment the `__builtin_clz*` compile down to `bsrq` on x86_64. Compiling with `-mlzcnt` wires up the actual instruction. `CountBits` without `-mlzcnt`: ```asm _Z9CountBitsmi: .LFB189: .cfi_startproc endbr64 xorl %eax, %eax...
This came up in a discussion with @madars yesterday. Using BLS signatures rather than Schnorr would allow for non-interactive signature aggregation. The benefit (which may not be worth the effort,...
These are the simple (and hopefully obviously correct) copies that can be moves instead. This is a follow-up from https://github.com/bitcoin/bitcoin/pull/30094#issuecomment-2108751842 As it turns out, there are hundreds of places where...
Forbid thread_local vars with non-trivial destructors. This is a follow-up from: https://github.com/bitcoin/bitcoin/pull/30095#discussion_r1608423170
PR'ing this early as an RFC because it's a lot of work that will require constant rebasing. This is the first logical step and is mostly mechanical. This PR adds...
DumpMempool/LoadMempool are not necessary for the kernel. Noticed while working on instantiated logging. I suppose these could have been left in on purpose, but I'm assuming it was probably just...
Noticed while testing a branch that replaces `boost::multi_index` with a custom replacement. Currently depends builds pick up usdt and boost from the same path, and because boost always exists, the...
See [Upstream docs](https://cmake.org/cmake/help/latest/variable/CMAKE_SKIP_TEST_ALL_DEPENDENCY.html) for specifics. Unfortunately, this **seems to have no effect when directly executing `ctest`** :( This brings the test -> hack -> test cycle more inline with how...