Cory Fields

Nice, that one's already done :) I'll update it and we'll start with that one instead.

Heh, really sorry @fanquake . I think the out-of-tree approach makes sense for (for example) [plugins where we can create attributes and assign them meaning](https://github.com/theuni/bitcoin-core-clang-plugin/commit/05fb23f21df32df4445951123d281172b12ee61b). In that case, the "atomicity"...

As @fanquake mentioned, some of these are only warnings in older compilers. I'm going through them to double-check that they are indeed non-issues, as opposed to missed warnings in newer...

I also pushed a patch for systemtap in depends that gets rid of those compiler warnings. From what I can tell, the variadic is completely unused there, but I'm not...

Concept ACK, btw :)

> With the `_OVERLAPPED` fix applied, the Win64 job fails differently: > > ```shell > /usr/bin/ccache x86_64-w64-mingw32-g++-posix -std=c++17 -DHAVE_CONFIG_H -I. -I../src/config -fmacro-prefix-map=/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-w64-mingw32=. -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -DHAVE_BUILD_INFO -D_MT -DWIN32 -D_WINDOWS -D_WIN32_WINNT=0x0601 -D_WIN32_IE=0x0501...

Here's a slightly more invasive change that eliminates the possibility of undefined behavior by filtering out script versions that can't be consumed by these functions: https://github.com/theuni/bitcoin/commits/explicit-v1-scriptver The key idea is...

> I too think that we don't use the variadic and it's Ok to drop it in the patch: > > We use, for example, the `DTRACE_PROBE6(context, event, a, b,...

> > Here's a slightly more invasive change that eliminates the possibility of undefined behavior > > Strictly speaking, this will keep the UB. Recall that an `enum class` is...

utACK with or without @hebasto's additional changes.