Cory Fields

Results 148 comments of Cory Fields

Are there some docs somewhere that suggest this?

I'm not sure this is a problem? It's hard to imagine a use-case where we'd want to be debugging Core with an un-optimized secp.

`ComputeTapTweak` is more like what I had in mind, yes.

PR description needs an update too :)

I guess the idea is that there's basically nothing worth salvaging from our current Android build procedure?

I think the original bug here illustrates that the enum is not well suited for this. Definitely not with a value of 0 for NO_LIMIT anyway. Got any other ideas?...

I'm not sure I see the value in using an enum (and forcing it to be passed in) over simply defining a constant? If there's more than 1 possible value,...

ACK retracted until resolving https://github.com/bitcoin/bitcoin/pull/30047#discussion_r1597108664.