Cory Fields

Results 148 comments of Cory Fields

Concept ACK. Looking at the [leveldb godbolt link](https://godbolt.org/z/45S0ID), this is nicely optimized everywhere except MSVC. I'm ok with a possible regression there for the sake of the cleanup.

Want to upstream the crc32 patch to match the others we have sitting there?

@hebasto Is there a venue for reporting this to MSVC? They recently [patted themselves on the back for detecting similar patterns](https://devblogs.microsoft.com/cppblog/a-tour-of-4-msvc-backend-improvements/). It's a shame MSVC can't detect something that (in...

@maflcko FWIW, I just suggested that c-i be hooked up so that we could see what real-world usage of the flags would be. I didn't mean to imply that it...

Imo this should be renamed "Add CMake buildsystem". I looked for this a while back and didn't find it because CMake isn't mentioned in the title. Concept ACK. Will review...

@sipa Are you interested in CMake for this project?

@sipa No rush. I was just looking for a concept ACK. I worked up a CMake impl as well before seeing this PR. I think we'd benefit from parts of...

> Coin selection, aggregation (-UTXOs) Thought about this for a while after our discussion yesterday. One of the worst-case problems to solve is: how do I spend a million pennies?...

Regarding the custom lib/self-impl discussion in #30005: Taking a quick look at the implementation here, I think it's simple enough for us to maintain ourselves. If a nice canonical lib...