WebSocket-Node icon indicating copy to clipboard operation
WebSocket-Node copied to clipboard

Microsoft Edge does not like the W3CWebSocket wrapper

Open ibc opened this issue 8 years ago • 4 comments

Scenario:

A web application that uses browserify and a 3rd party JS library that uses WebSocket-Node to run in both browser and Node. So, when doing the browserify stuff, lib/browser.js is taken (which is just a wrapper of the native WebSocket in the browser).

However, Microsoft Edge 11 does not like it and fails ("invalid syntax"). It seems that this here does not point to window but to something strange (see the image):

screen shot 2017-12-08 at 02 57 25

I don't have an Edge browser so it will take some time before I can put my hands into this. In the meanwhile may be someone can help.

ibc avatar Dec 08 '17 02:12 ibc

I tried to reproduce this today using Microsoft Edge 44.17763.1.0,Microsoft EdgeHTML 18.17763, but I was unable to. It seemed to work fine.

Perhaps this works on newer versions of Edge? I don't have an easy way of testing on older versions.

Gudahtt avatar Jul 09 '19 12:07 Gudahtt

If Microsoft Edge 44.17763.1.0 uses Chromium, then there should be zero issues.

ibc avatar Jul 09 '19 13:07 ibc

It does not; the Chromium version hasn't been released yet. They have dev and canary builds available that use Chromium, but it's not stable yet.

Gudahtt avatar Jul 09 '19 13:07 Gudahtt

I am seeing this same issue - but in Chrome Version 75.0.3770.100 (Official Build) (64-bit). this is simply undefined: image

murphomatic avatar Jul 13 '19 01:07 murphomatic