Chad Condon

Results 92 comments of Chad Condon

This can also be overridden by users by passing `-DCPPUTEST_HAVE_FENV=` on the command line or with `set(CPPUTEST_HAVE_FENV CACHE BOOL "Enable IEEE754 exceptions plugin")` before including CppUTest.

I'm not sure I follow. This change switches from `#ifdef` to `#if`. The only remaining `#ifdef` is [here](https://github.com/cpputest/cpputest/pull/1579/files#diff-168ea8f21c7bc702090b8a90bbf94dd495f14956503fbafb7fff8e09933b377aR214) where I do what you describe: if a value for `CPPUTEST_HAVE_FENV` isn't...

gotcha. that makes sense. thanks for the explanation.

Nevermind. I'm still confused. It sounds like you want me to add a DISABLE macro used to set the HAVE macro when it isn't set? Why not let the user...

I think I've made the change you're asking for. Let me know what you think.

How's the CI effort going? Is there anything I could do to help?

``` src/CppUTestExt/../../include/CppUTestExt/MockCheckedActualCall.h:95:20: error: ‘virtual void (* MockCheckedActualCall::returnFunctionPointerValue())()’ can be marked override [-Werror=suggest-override] 95 | virtual void (*returnFunctionPointerValue())() _override; | ^~~~~~~~~~~~~~~~~~~~~~~~~~ src/CppUTestExt/../../include/CppUTestExt/MockCheckedActualCall.h:96:20: error: ‘virtual void (* MockCheckedActualCall::returnFunctionPointerValueOrDefault(void (*)()))()’ can be marked...

Yeah, it's definitely strange. It _feels_ like a gcc bug, but I reproduces across multiple versions of both gcc and clang.

Have you had a chance to look into this yet?

https://isocpp.org/wiki/faq/pointers-to-members#typedef-for-ptr-to-memfn