solid-devtools icon indicating copy to clipboard operation
solid-devtools copied to clipboard

Overlay not work

Open Farnsi opened this issue 2 years ago • 4 comments

It shows only: ReferenceError: Cannot access 'container9' before initialization

Does it work with@solidjs/router and lazy loaded components?

image

Chrome version 111.0.5563.146 Linux Mint 21.1

What can i do to ship more/better details?

Farnsi avatar Apr 01 '23 10:04 Farnsi

Thanks for the reports 🙏 Could you include your dependency versions? (solid, router)

thetarnav avatar Apr 01 '23 11:04 thetarnav

Same error:

@solidjs/router: ^0.8.2 solid-js: v1.7.0 vite-plugin-solid: v2.7.0

Though I am attempting to use in Electron.

Calhistorian avatar Apr 18 '23 18:04 Calhistorian

Same issue after updating.

@solid-devtools/overlay 0.6.0 
solid-js 1.7.5
vite-plugin-solid 2.7.0

image

let declarations are not hoisted...

This file is generated by vite.

vsviridov avatar May 18 '23 00:05 vsviridov

This is how the source code was written:

https://github.com/thetarnav/solid-devtools/blob/d0d7910e2b4acb709c698225a2819019fb253c2d/packages/frontend/src/modules/structure/Path.tsx#L17-L25

The problem might be that createElementSize used to call target in onMount, but now immediately:

https://github.com/solidjs-community/solid-primitives/commit/2f6d3732d4e0d18c2f123f90d9225e0924bcf765#diff-7b7a1aa744c704ff1f8a484e16ecc05716c8f6229ded8e7d5d3b2cd5606e18c5L210-L215

EDIT: #225 will fix this.

yume-chan avatar May 24 '23 09:05 yume-chan