thestonehead
refactor completely to make compatible with TB140 to fix #35
Code has been completely refactored to work with Thunderbird 140 to fix #35. Backward compatibility has not been tested. The PR comprises the following changes:
- modularize for reusability
- move crucial parts to Experiment API
- improve const correctness
- keep almost all functionality of 1.8.2, only remove listing of non-extractable attachments
- require confirmation by user before overwriting files during extraction
- provide more details to user, such as number of extracted attachments
- deduplicate listing of files to be deleted
- fixes #27 to use filename when canceling template pattern for filenames
- addresses issues with wording to partly fix #29
Sounds perfect! Do you have any plans to bring this new version to addons.thunderbird.net?
First of all, thank you for this refactoring job! :) Unfortunately it does not work (nothing happens) if the selected items include e-mails without attachments or e-mails containing an attachment with the .eml extension.
@piterq Can not confirm this. If I select messages with and without attachments at the same time, I get a corresponding message like Only 2 of your 7 selected messages contain extractable attachments. and the extraction works as expected.
.eml attachments work for me as well in this scenario.
@de-es It works correctly on IMAP accounts. In my case this was on POP3 account and I can reproduce it right now. I'm using meigelb refactored version on Thunderbird 140.4.0 esr.
Just append or replace .xpi to the following zip file. Then you have the updated extension with the changes from meigelb.
[email protected]
The repo owner @thestonehead has had no activity in this whole year. @meigelb or I can create a new addon listing.
The repo owner @thestonehead has had no activity in this whole year. @meigelb or I can create a new addon listing.
Would love to see that, would make integration much smoother
