Sioni Summers

Apologies for the late followup review. This looks really nice now, all these implemented options are useful. The problems now are: - some tests fail, including ones testing the new...

I transferred this issue from the hls4ml-tutorial repo since it's more relevant here.

Thanks for this, it's a lot of work. I'll take a look at why the pytests fail, it's the test job generation step that fails, not even the pytests themselves....

I saw that the new qonnx test fails due to missing `qonnx` in the test image environment. I've updated the test image, and pushed a commit to pick it up....

> I initially made the optimizers propagate all precisions, but this proved to be bad if you left the default ap_fixed since you wound up with huge accumulators. I wanted...

Hi, For the tutorial projects you can find the generated RTL under, for example `model_1/hls4ml_prj/myproject_prj/solution1/impl/{verilog, vhdl}`. This is the RTL of the NN IP. To generate a bitstream that you...

Great! I made the WIP/hacky PR #342 with the idea to make the HLS generate easier to parse reports that may be relevant.

What I mean is, right now our templates are the strings needed to call the function, e.g. for Dense: `dense_function_template = 'nnet::dense({input}, {output}, {w}, {b});'`, which might become this in...

I haven't tried out your code, but from your message, I think renaming `XilinxPart` to `Part` should fix it. The master branch is undergoing many changes, including to the API,...

Hi @jmduarte, all the updates sounds good to me. I know @nicologhielmetti has begun the work to port the FIFO depth optimization to an optimizer pass on top of the...