sof icon indicating copy to clipboard operation
sof copied to clipboard

scripts/cmake: Set SOF_MICRO to 99 on main branch

Open SurajSonawane2415 opened this issue 9 months ago • 4 comments

Set SOF_MICRO to 99 on the main branch

This change ensures that SOF_MICRO is set to 99 when on the main branch, similar to Zephyr’s approach for never-released branches. For other branches, it remains 0 to maintain consistency with xtensa-build-zephyr.py.

Fixes the TODO:

"default this to .99 on the main, never released branch like zephyr does"

Changes:

Detect the current Git branch using git rev-parse --abbrev-ref HEAD
Set SOF_MICRO to 99 if on main, otherwise 0

Testing:

Verified SOF_MICRO = 99 on main, 0 on other branches by running:

 cmake -DSOF_ROOT_SOURCE_DIRECTORY=$(pwd) -P scripts/cmake/version.cmake

I would appreciate your review and any suggestions for improvement. Thank you!

SurajSonawane2415 avatar Mar 05 '25 07:03 SurajSonawane2415

Can one of the admins verify this patch?

reply test this please to run this test once

sofci avatar Mar 05 '25 07:03 sofci

test this please

lgirdwood avatar Mar 05 '25 10:03 lgirdwood

Two checks previously failed due to:

  • WARNING: Missing commit description - Add an appropriate one
  • ERROR: Missing Signed-off-by: line(s)

I have amended the commit to include the commit description and Signed-off-by line to resolve these issues.

SurajSonawane2415 avatar Mar 05 '25 11:03 SurajSonawane2415

No objections from me, aligning with Zephyr makes sense.

Thank you for your review!

SurajSonawane2415 avatar Mar 05 '25 12:03 SurajSonawane2415