sof icon indicating copy to clipboard operation
sof copied to clipboard

[DNM]Tools: Testbench: Change file IPC3 init to be process compatible

Open singalsu opened this issue 1 year ago • 6 comments

I'm having doubts for this approach to avoid revert of #9518. There might be need to change some component's IPC structures, e.g. volume, to be able to initialize with process type IPC as SOF_COMP_MODULE_ADAPTER.

singalsu avatar Oct 01 '24 12:10 singalsu

@singalsu in the future we could probably get rid of type completely for IPC4. IPC3 could have a lookup able that converts type to UUID for module lookup. Btw, conflicts.

lgirdwood avatar Oct 01 '24 13:10 lgirdwood

@singalsu in the future we could probably get rid of type completely for IPC4. IPC3 could have a lookup able that converts type to UUID for module lookup. Btw, conflicts.

What do you think of this version? The testbench CI step works (should -- checked so far only locally) but I've had to remove Volume and SRC component tests since there is currently no solution to load them to IPC3 testbench.

singalsu avatar Oct 01 '24 16:10 singalsu

@lgirdwood @cujomalainey #9518 revert is now merged so this is no more needed. I'll close this for now since this patch adds no value. But I have the work in my git tree so we can re-introduce the check later as better prepared.

singalsu avatar Oct 02 '24 07:10 singalsu

@singalsu please keep the work around as the fix is going to be applied, but we need to fix stuff before it lands.

cujomalainey avatar Oct 02 '24 13:10 cujomalainey

@singalsu please keep the work around as the fix is going to be applied, but we need to fix stuff before it lands.

OK, I'll keep the draft open, so also other can use these changes.

singalsu avatar Oct 03 '24 07:10 singalsu

Current draft (not validated yet) won't need this, but lets keep it until we validate the work

cujomalainey avatar Oct 04 '24 13:10 cujomalainey