thesofproject
copier: Add bind function to configure source/sink buffers params
Setting the source/sink buffers parameters in the copier_update_params function is not sufficient. If a sink buffer is attached during copier operation, the module will not set buffers parameters. Move the buffer parameter configurations to the new copier_bind bind function. Delete the sink buffers configurations from the copier_module_copy function. There is no need to configure sink buffers parameters on each copy. We are assured that they were configured at the time of bind.
Fixes: #9123
@softwarecki can you confirm if internal CI is good to merge ? Seeing some red on Jenkins, lets rerun to be sure.
I restored the code that sets the sink parameters in the copier_update_params function. Parameters set in the bind function can be overwritten by the comp_verify_params function called by ipc4_pipeline_prepare -> ipc4_pipeline_params.
I look forward to the new CI results...
I restored the code that sets the sink parameters in the
copier_update_paramsfunction. Parameters set in thebindfunction can be overwritten by thecomp_verify_paramsfunction called byipc4_pipeline_prepare->ipc4_pipeline_params.I look forward to the new CI results...
All look good except for LNL SDW, can you check ? I would expect copier changes to fail on all test (not just SDW), we can rerun again if you think its DUT or testing infra related.
@lgirdwood wrote:
All look good except for LNL SDW, can you check ? I would expect copier changes to fail on all test (not just SDW), we can rerun again if you think its DUT or testing infra related.
The LNL SDW is caused by this: https://github.com/thesofproject/linux/issues/5098
The pause/resume failure in https://sof-ci.01.org/sofpr/PR9276/build6454/devicetest/index.html?model=LNLM_RVP_HDA&testcase=check-pause-resume-capture-100 is addressed by https://github.com/thesofproject/sof-test/pull/1218, please review.
