sof icon indicating copy to clipboard operation
sof copied to clipboard

[DNM] dai-zephyr: use frames aligned for multi-endpoint copy

Open iganakov opened this issue 1 year ago • 8 comments

When aggregating streams using dai_zephyr_multi_endpoint_copy() multiple glitches observed in audio streams with odd number of channels. Use audio_stream_avail_frames_aligned() for every dai in a loop to correctly calculate processing frames.

iganakov avatar Jun 05 '24 07:06 iganakov

This doesn't look good in the CI results https://sof-ci.01.org/sofpr/PR9196/build5811/devicetest/index.html?model=LNLM_SDW_AIOC&testcase=check-playback-10sec I don't think we have this in baseline.

kv2019i avatar Jun 20 '24 11:06 kv2019i

This doesn't look good in the CI results https://sof-ci.01.org/sofpr/PR9196/build5811/devicetest/index.html?model=LNLM_SDW_AIOC&testcase=check-playback-10sec I don't think we have this in baseline.

@iganakov I dont think any of the CI tests are doing odd number of channels wrt the number of test failures, this looks like we have impact on even channel numbers too.

lgirdwood avatar Jun 25 '24 15:06 lgirdwood

@kv2019i @lgirdwood I'm able to reproduce the issue with Windows driver also. Looks like something has changed in FW since I implemented this fix some time ago. Let me find the root cause.

iganakov avatar Jun 27 '24 07:06 iganakov

Release reminder - one week to v2.11-rc1.

kv2019i avatar Sep 06 '24 10:09 kv2019i

@iganakov any update ?

lgirdwood avatar Nov 07 '24 14:11 lgirdwood

Feature cutoff for v2.12 today, @iganakov any update? This is a bugfix, so we can still take it to the release, but at minimum needs a rebase.

kv2019i avatar Dec 13 '24 12:12 kv2019i

Stable v2.13 branched, moving this forward.

kv2019i avatar Jan 03 '25 10:01 kv2019i

No update in two releases, moving to TBD milesotne. FYI @iganakov @abonislawski

kv2019i avatar Apr 23 '25 13:04 kv2019i