thesofproject
Telemetry2 thread info
One major change idea for this would be making each core data to have its own chunk. In the end it would same couple of bytes and maybe look a bit cleaner. A down side would be the core specific chunks be there in the telemetry2 slot in 'random' order depending on which cores are started up first.
Applied all pending comments, but the big question about the new telemetry slots name is still unanswered. What about telemetry_v2, that would indicate that telemetry_v2 is trying to be a super-set of telemetry (v1) and while it can coexist with it, it can also make it obsolete. There is probably also still more comments to be written.
telemetry_v2 is trying to be a super-set of telemetry (v1) and while it can coexist with it, it can also make it obsolete.
That really requires explanations !
telemetry_v2 is trying to be a super-set of telemetry (v1) and while it can coexist with it, it can also make it obsolete.
That really requires explanations !
Intention is to be able to see Zephyr RTOS resources in realtime, not break backwards compatibility with existing telemetry and grow alongside Zephyr. Today only 1 backend, the mem Window, but should also work with probes in future.
V2 naming is really about the ABI, i.e. the feature supports existing "v1" telemetry for compatibility (do not break and can embed) but v2 is to exploit all the data that is available via Zephyr RTOS APIs around scheduling, memory, IRQs, locking, MMU, PM etc.
Expectation is that Zephyr data will grow/change over time hence an IPC based data format is used that will allow ABI growth and wont break tooling.
Made some necessary updated due to changes to my PR on Zephyr side (https://github.com/zephyrproject-rtos/zephyr/pull/71408) and while at it, added some text to telemetry2 (I did not change the name just yet) commit message and associated Kconfig help section and header. Also added a commit to increase debug window size from 12k to 16k.
Update the implementation to use the latest API update for this PR: https://github.com/zephyrproject-rtos/zephyr/pull/71408
Also some updates to code comments. Got rid of C++ //-comments.
Relax locking for telemetry2 chunk reservation. Fix some minor style issues.
@jsarha any updates ? I think we should have all Zephyr commits upstream now ? Can you rebase too.
@lgirdwood I am currently doing (or actually re-spinning after two week bug-hunt break) the major rework to change to debug window protocol to core specific circular buffers, you requested. I do not expect it to be ready before end of the week, when I start my two week summer vacation, but I hope it does not take more than another week after that.
@jsarha This can be closed now with https://github.com/thesofproject/sof/pull/9398 merged ?
