sof icon indicating copy to clipboard operation
sof copied to clipboard

topology2: add support for MTL Acer Swift Go 14

Open plbossart opened this issue 1 year ago • 3 comments

This device has RT712 on link0 2 PCH-attached DMICs.

Add 3 configurations with no DMIC, 4 DMIC and 2 DMIC. For now no support for -pdm1.

Link: https://github.com/thesofproject/linux/issues/4923

plbossart avatar Apr 12 '24 21:04 plbossart

v2 updated with suggested changes from @bardliao. Thanks Bard.

plbossart avatar Apr 15 '24 14:04 plbossart

LGTM, but better to wait for the test result of thesofproject/linux#4923

Ok, @bardliao pls ping when the tests pass. Thanks !

lgirdwood avatar Apr 17 '24 11:04 lgirdwood

LGTM, but better to wait for the test result of thesofproject/linux#4923

Ok, @bardliao pls ping when the tests pass. Thanks !

@lgirdwood From https://github.com/thesofproject/linux/issues/4970, this PR should be good. The DSP panic looks like a different issue.

bardliao avatar Apr 29 '24 05:04 bardliao

What's the current status on this? Thanks

thedanhoffman avatar Jul 28 '24 17:07 thedanhoffman

What's the current status on this? Thanks

still being tested, see https://github.com/thesofproject/linux/issues/4970

plbossart avatar Jul 29 '24 07:07 plbossart

@plbossart Finally Acer Swift Go 14 works with UCM https://github.com/thesofproject/linux/issues/4923#issuecomment-2264738892. My only open for this PR is that we have sof-mtl-rt712-l0 in the existing topology. The sof-mtl-rt712-l0 doesn't have either SDW DMIC or PCH DMIC support and use the default HDMI_IDs. This doesn't look right.

bardliao avatar Aug 02 '24 08:08 bardliao

Maybe split the PR into 2 commits, one to edit the HDMI_IDs ie. HDMI1_ID=3,HDMI2_ID=4,HDMI3_ID=5 for sof-mtl-rt712-l0 and the other add sof-mtl-rt712-l0-2ch and sof-mtl-rt712-l0-4ch

bardliao avatar Aug 02 '24 08:08 bardliao

@bardliao do you mind submitting your changes directly in a new PR? I don't really know what you sent for testing so likely I'll screw-up...

plbossart avatar Aug 02 '24 08:08 plbossart

@bardliao do you mind submitting your changes directly in a new PR? I don't really know what you sent for testing so likely I'll screw-up...

Sure, will do.

bardliao avatar Aug 02 '24 08:08 bardliao

ok, thanks @bardliao I'll close this PR then

plbossart avatar Aug 02 '24 11:08 plbossart