[FEATURE] tplg build should catch too long control names

[kv2019i]

Is your feature request related to a problem? Please describe. Currently SOF topologies can be created with too long control names and these will fail upn Linux kernel loading the topologies.

Describe the solution you'd like It should be possible to constraint length of "string" data and capture invalid entries at topology build time.

Describe alternatives you've considered

Additional context Filed as result of https://github.com/thesofproject/sof/pull/9008

[lgirdwood]

@ranj063 @jsarha @singalsu lets include this fix in our topology Q2 work. Thanks

[jsarha]

I can take this. Thou I guess this is not a top prioroty.

[kv2019i]

Not a priority item, pushing to next.

[kv2019i]

Feature cutoff for v2.12, moving this to v2.13.

[kv2019i]

@jsarha any update? two weeks for v2.13 feature cutoff.

[jsarha]

@kv2019i there has constantly been higher priority jobs assigned to me, so this has not gotten any cycles.

[kv2019i]

Ack @jsarha . Let me move to TBD milestone and we'll reschedule this later.

[Biancaa-R]

@kv2019i I tried approaching this my modifying tplg_parser/control.c ,is there a better way you would suggest or any pointers to fix this issue ,I am quite new to Sof :/

[lgirdwood]

Adding @ranj063 @Biancaa-R the topology compiler (in ALSA utils) does all the topology building from topology source to binary. This code parses the input before outputing to binary structures in file and would also need a similar size check. Fwiw, I am not sure if the front end parser knows the target size when parsing, I would probably add any checks to the back end of the compiler where the target object size is known.

[Biancaa-R]

Adding @ranj063 @Biancaa-R the topology compiler (in ALSA utils) does all the topology building from topology source to binary. This code parses the input before outputing to binary structures in file and would also need a similar size check. Fwiw, I am not sure if the front end parser knows the target size when parsing, I would probably add any checks to the back end of the compiler where the target object size is known.

Thanks a lot for your input Ill change it accordingly.

[kv2019i]

Thank you for the contribution @Biancaa-R ! I don't actually know where exactly this check for errors should be made, but I think the tplg_parser is not the right place as that is not run during the build process for topologies. I'm suspecting the correct place is in the conf2tplg compiler in ( https://github.com/alsa-project/alsa-utils/commits/master/topology ). Did you @jsarha took a look at all where this could be done?

For background, we want to avoid errors like was fixed here https://github.com/thesofproject/sof/pull/9008 Sorry @Biancaa-R , this may not be the easiest issue to start in SOF.

[jsarha]

@kv2019i , The correct place would of course be the alsa-utils topology compiler, but I have not taken on the task since there has all the time been higher priority tasks in my queue, and respinning a topology compiler work will always take some time. An adhock solution of writing a python checker for our topologies on top of already existing parser, would be faster, but not as elegant solution.