thesofproject
[stable-v2.2] topology1: Add changes to generate the topology for SSP codec+HDMI-in…
… capture+DMIC.
Add cmake changes to generate the topology file for the products which need to support SSP based codec,HDMI-in capture via I2S and DMIC.
Commit titles should pack as much information as possible in a very limited space. Example:
Add cmake changes to support the generation of the topology which can be used to support X, Y Z...
=> Add topology for X, Y, Z...
(this is not really CMake code, it's just a list that happens to be implemented in CMake)
Also, for review convenience, next time please update the Pull Request description and keep it in sync when force-pushing a new commit message.
Github is not really designed for force-pushes (no git range-diff)
https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers
Commit titles should pack as much information as possible in a very limited space. Example:
Add cmake changes to support the generation of the topology which can be used to support X, Y Z...
=> Add topology for X, Y, Z...
(this is not really CMake code, it's just a list that happens to be implemented in CMake)
Updated the commit message and PR description as you suggested. please check.
@wszypelt , @lrudyX : very worrying (and unrelated) build failure in https://sof-ci.01.org/sof-pr-viewer/#/build/PR8993/build13802926, can you please take a look?
west init -l sof
23:22:30,371 DEBUG - Command working directory: /buildagent/workspace/24733
23:22:30,518 WARN - FATAL ERROR: can't init: no west.yml found in /buildagent/workspace/24733/sof
Updated the commit message and PR description as you suggested. please check.
Looks good, thanks for the extra effort!