thesofproject
[DNM] audio: copier: use v_index for DAI index in I2S link creation
This commit updates the copier DAI creation logic for I2S links to use the v_index field from the node_id structure as the DAI index. This change ensures that the correct DAI index is used when creating I2S links, aligning with the new SSP link management mechanism.
This PR is related to https://github.com/zephyrproject-rtos/zephyr/pull/70660 - Still in development
before merging we need to make sure that all 'nocodec' kernel tests pass, that's where we test the SSP mostly along with the topology definitions/blobs..
before merging we need to make sure that all 'nocodec' kernel tests pass, that's where we test the SSP mostly along with the topology definitions/blobs..
Of course, I agree with that. I am currently trying to understand why some of the 'nocodec' type tests are not starting.
@dnikodem @plbossart looks like all nocodec tests are working - does this mean we are ready now for non draft ?
@dnikodem @plbossart looks like all nocodec tests are working - does this mean we are ready now for non draft ?
For my part - I am waiting for the "final" confirmation from the validation team (this is related to the recent changes in the zephyr part). The results should be available tomorrow.
Referring to Wojciech's comment from the Zephyr part:
wszypelt commented 2 days ago • @dnikodem @kv2019i Based on the SOF PR 8980, I checked the changes for MTL and LNL, in MTL everything works properly, in LNL I have to wait a while until all the tests are done, however, I can tell you that so far everything looks good. I will write again as soon as all tests are completed
wszypelt commented yesterday @dnikodem @kv2019i all LNL tests look good :)
Rebased because the number of SSP devices was reduced with other PR: https://github.com/thesofproject/sof/pull/9053
Can I ask where this 'v_index' is set?
topology? NHLT blob inserted in topology?
in the latter case, @singalsu @jsarha can you confirm alsa-utils does set this field in the blob?
Can I ask where this 'v_index' is set?
topology? NHLT blob inserted in topology?
in the latter case, @singalsu @jsarha can you confirm alsa-utils does set this field in the blob?
@dnikodem can you confirm where v_index comes from, e.g. IPC, NHLT, topology ? Thanks !
Can I ask where this 'v_index' is set? topology? NHLT blob inserted in topology? in the latter case, @singalsu @jsarha can you confirm alsa-utils does set this field in the blob?
@dnikodem can you confirm where v_index comes from, e.g. IPC, NHLT, topology ? Thanks !
The v_index is coming from topology (it is essentially the SOF_TKN_DAI_INDEX token of a DAI copier.
For SSP we set it into the node_id |= dai_index << 4; and bit0-3 is unused for SSP.
In future platforms we might pass additional information for SSP selection via bit0-3 and this is what this patch is preparing for. Note: Linux will always pass 0 as bit0-3 for now, which might not need to be changed at all.
@dnikodem rebase needed and draft status to be changed.
Sure, I'll do it, but before we merge it, we need to merge the zephyr part: https://github.com/zephyrproject-rtos/zephyr/pull/70660
It seems that CI failures are not related to these PR changes.
@wszypelt @lrudyX safe to merge ?
It seems that CI failures are not related to these PR changes.
@wszypelt @lrudyX safe to merge ?
This PR was actually validated as green, CI failed after testing.
It seems that CI failures are not related to these PR changes.
@wszypelt @lrudyX safe to merge ?
This PR was actually validated as green, CI failed after testing.
Thanks @lrudyX, I will merge.