thesofproject
Re-introducing state change in dai_comp_trigger_internal() breaks some tests from Intel CI
Attempting to bring back the state transition logic in dai-zephyr's dai_comp_trigger_internal() that was initially removed by 6ffb0526910e0d3410f3a9dd5b68457d359cc8f4 seems to break some tests from the Intel CI. The logic is needed for NXP platforms and is re-introduced by https://github.com/thesofproject/sof/pull/8859 via 59d05a318982142e862374dccd481b449ed33e88.
As a workaround, the state transition logic has been made IPC3-specific but it might be worth looking into this and trying to make the code IPC version-agnostic if possible.
Links to the aforementioned failing CI builds:
- https://sof-ci.01.org/sofpr/PR8859/build3069/devicetest/index.html
- https://sof-ci.01.org/sofpr/PR8859/build3070/devicetest/index.html
- https://sof-ci.01.org/sof-pr-viewer/#/build/PR8859/build13666634 (internal build)
@LaurentiuM1234 probably the best thing todo is to break down the changes into small bi-sectable patches and upstream them incrementally. This would allow more specific targeting when the issue is introduced.
