sof icon indicating copy to clipboard operation
sof copied to clipboard

Audio: aec: optimize acoustic echo cancellation processing

Open ShriramShastry opened this issue 1 year ago • 10 comments

This check-in introduces performance optimization modifications to the audio Echo Cancellation (AEC) implementation. The enhancements primarily focus on refining loop structures and memory copy operations to ensure more efficient use of cycles.

ShriramShastry avatar Feb 21 '24 16:02 ShriramShastry

@thesofproject/google pls review. Thanks !

lgirdwood avatar Feb 26 '24 16:02 lgirdwood

@ShriramShastry could you please explain in simple terms what exactly you're trying to optimise in this PR - which algorithms you find non-optimal, how you replace them, and - very importantly - how you test the result? Can you provide a single simple example like "I take this kind of a loop and replace it with this and this brings X% performance gain?"

lyakh avatar Feb 27 '24 07:02 lyakh

Sorry but google is going to NACK this until we at least get a release and stabilize this component first

cujomalainey avatar Feb 28 '24 17:02 cujomalainey

Sorry but google is going to NACK this until we at least get a release and stabilize this component first

Okay, we'll wait till the release and stable component are available.

ShriramShastry avatar Feb 29 '24 04:02 ShriramShastry

@ShriramShastry could you please explain in simple terms what exactly you're trying to optimise in this PR - which algorithms you find non-optimal, how you replace them, and - very importantly - how you test the result? Can you provide a single simple example like "I take this kind of a loop and replace it with this and this brings X% performance gain?"

Sure, The initial test measurements are taken per loop. The results are positive. @yongzhi1 , could you kindly help with the current updates and communicate the information here?

Thank you

ShriramShastry avatar Feb 29 '24 05:02 ShriramShastry

Sorry but google is going to NACK this until we at least get a release and stabilize this component first

Okay, we'll wait till the release and stable component are available.

Pushing it out to v2.10 to allow stabilization, baseline MCPS measurements and alignment.

lgirdwood avatar Feb 29 '24 13:02 lgirdwood

Sorry but google is going to NACK this until we at least get a release and stabilize this component first

Okay, we'll wait till the release and stable component are available.

Thanks :) just remember, premature optimization is the root of all evil

cujomalainey avatar Feb 29 '24 17:02 cujomalainey

Sorry but google is going to NACK this until we at least get a release and stabilize this component first

Okay, we'll wait till the release and stable component are available.

Thanks :) just remember, premature optimization is the root of all evil

Do you have any progress ? Thanks

ShriramShastry avatar May 09 '24 13:05 ShriramShastry