sof icon indicating copy to clipboard operation
sof copied to clipboard

base_fw: update mem_state_info TLV

Open dnikodem opened this issue 1 year ago • 1 comments

This change improves the TLV assembly algorithm in accordance with how the part for hpsram is assembled. In the case when ebb_state_dword_count is equal to 0, we skip adding the LSPGCTL register value for lpsram.

dnikodem avatar Feb 19 '24 09:02 dnikodem

Added https://github.com/zephyrproject-rtos/zephyr/pull/70221 - this is the first step to clean up SOF headers.

dnikodem avatar Mar 17 '24 18:03 dnikodem

@dnikodem I assume you will make non draft after the Zephyr part is merged and we can rebase/merge.

correct, we need firstly zephyr part merged.

dnikodem avatar Apr 16 '24 12:04 dnikodem

Oops, @dnikodem I didn't realize this PR was still open as well. I was intending to get he pending base_fw changes out of the wait, but missed this one. This will now conflict with https://github.com/thesofproject/sof/pull/9103

Let's see which gets the reviews together first, and then rebase the other one.

kv2019i avatar May 07 '24 11:05 kv2019i

Oops, @dnikodem I didn't realize this PR was still open as well. I was intending to get he pending base_fw changes out of the wait, but missed this one. This will now conflict with #9103

Let's see which gets the reviews together first, and then rebase the other one.

oh, yeah - this one was blocked on Zephyr PR merging (now merged). @dnikodem do we need a west update ? I think @kv2019i did a west update a few days ago so we may be good just to rebase this ?

lgirdwood avatar May 08 '24 10:05 lgirdwood

Yes, the west was updated by Kai and points on correct commit. Here is needed to rebase / resolve conflict with base_fw_platform.c file. I will do this today.

dnikodem avatar May 08 '24 10:05 dnikodem