thesofproject
[SKIP SOF-TEST] Add initial Google CTC component
@eddy1021 , minor Github trick:
https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers
Respond to comments using the “Start Review” and “Add Review” green buttons in the “Files changed” view. This allows responding to multiple comments and publishing the responses in bulk. This reduces the number of emails sent to reviewers.
@eddy1021 I noticed a relatively high frequency of force-pushes in this PR which is why I added the magic tag [SKIP SOF-TEST] to stop hardware running sof-test for this PR.
Which github workflow are you struggling to reproduce locally? I take great care in making sure all workflows can be reproduced locally (and relatively easily) so if you're struggling anywhere then please let us know.
While it's a very common issue outside SOF, we really don't want CI to test one thing while developers test another.
The testbench build failures are compile warnings that are probably easy to fix:
Yes, there's an unused variable.
/home/runner/work/sof/sof/src/audio/google/google_ctc_audio_processing.c: In function ‘ctc_init’:
/home/runner/work/sof/sof/src/audio/google/google_ctc_audio_processing.c:265:29: error: unused variable ‘md’ [-Werror=unused-variable]
265 | struct module_data *md = &mod->priv;
| ^~
cc1: all warnings being treated as errors
