sof icon indicating copy to clipboard operation
sof copied to clipboard

Loadable up down mixer

Open pjdobrowolski opened this issue 2 years ago • 9 comments

This is an module_example of loadable up_down_mixer with lmdk.

pjdobrowolski avatar Dec 21 '23 15:12 pjdobrowolski

@pjdobrowolski are you using a 3rd party binary for the mixer OR just the code we have in the SOF repo? Or, does it matter?

dbaluta avatar Jan 10 '24 14:01 dbaluta

@pjdobrowolski are you using a 3rd party binary for the mixer OR just the code we have in the SOF repo? Or, does it matter?

This is the example how to convert up_down_mixer from SOF repo to loadable version. Only requirement for conversion is to set UPDWMIX to know in configuration to exclude up_down_mixer from build_in modules.

pjdobrowolski avatar Jan 11 '24 06:01 pjdobrowolski

this is draft quality at best

You are welcome.

pjdobrowolski avatar Jan 11 '24 08:01 pjdobrowolski

Changed to draft, module will be moved to https://github.com/thesofproject/converged-sof-modules

pjdobrowolski avatar Jan 22 '24 11:01 pjdobrowolski

Changed to draft, module will be moved to https://github.com/thesofproject/converged-sof-modules

No, this repo was temporary and for staging only prior to module API, IPC4 etc being upstream in main. All the dependencies are now upstream so all library support should go upstream. We also cannot duplicate our modules in two places.

This repo will be moving to archived state, there is no need to keep it today.

lgirdwood avatar Jan 24 '24 15:01 lgirdwood

Ok, I removed all unnecessary MODULE_PRIVAT tags and created exported headers from sof. Now up_down_mixer is building outside of sof. @softwarecki now we must create some kind of git/python verification script to check if these headers change or what happen with them for ABI verification.

pjdobrowolski avatar Jan 25 '24 14:01 pjdobrowolski

please check https://github.com/thesofproject/sof/pull/8554. We don't need to copy headers to lmdk.

RanderWang avatar Jan 29 '24 07:01 RanderWang

llext and native loadable modules are not the same.

pjdobrowolski avatar Jan 29 '24 07:01 pjdobrowolski

llext and native loadable modules are not the same.

@pjdobrowolski what @RanderWang is talking about isn't an LLEXT module, it's what you call a "native" system-service module, that he has submitted, you still don't need to copy headers for those

lyakh avatar Jan 29 '24 07:01 lyakh