sof icon indicating copy to clipboard operation
sof copied to clipboard

[FEATURE] Support ssp early start of MCLK/BCLK in IPC4, FW/tplg part

Open kv2019i opened this issue 2 years ago • 8 comments

Is your feature request related to a problem? Please describe. FW counterpart to Linux kernel side issue https://github.com/thesofproject/linux/issues/4514

Describe the solution you'd like Need definition of the IPC4 interface for this feature and potentially split work to Zephyr (for ssp driver) and alsa-utils (possible changes to tplg config blob generation).

kv2019i avatar Nov 24 '23 19:11 kv2019i

FYI @Vamshigopal @plbossart @mwasko @ranj063

kv2019i avatar Nov 24 '23 19:11 kv2019i

Based on quick look, the alsa-utils NHLT generator does fill

Furthermore, current ssp driver for Intel hardware, enables MCLK and BCLK always in early mode, triggering the clocks when module is initialized. The driver does parse the aux part of the blob (that contains the controls to configure aspects of early clocks), but there is no functionality here, just a debug print:

zephyr/drivers/dai/intel/ssp/ssp.c

»       »       case SSP_DMA_CLK_CONTROLS_EXT:
»       »       »       ext = (struct ssp_intel_ext_ctl *)&aux_tlv->val;
»       »       »       LOG_INF("%s ext ext_data %u", __func__, ext->ext_data);
»       »       »       break;

kv2019i avatar Nov 24 '23 20:11 kv2019i

And for the record the solution MUST scale to ACE2.0/LNL with the link DMA triggered by the host.

plbossart avatar Nov 27 '23 18:11 plbossart

Stable-v2.9 branched, this didn't make the cut, bumping to 2.10.

kv2019i avatar Mar 04 '24 13:03 kv2019i

@ujfalusi need you to check if this is already done

lrudyX avatar May 10 '24 08:05 lrudyX

@kv2019i, I'm genuinely surprised and don't get how this works in IPC4. We unconditionally set SSP_CLK_MCLK_ES_REQ and SSP_CLK_BCLK_ES_REQ in dai_ssp_set_config_blob() but for the BCLK to be really running the port also needs to be enabled, which is only done at start.

@lrudyX, I don't think anyone worked on this feature and I think it is not supported.

ujfalusi avatar May 10 '24 08:05 ujfalusi