sof icon indicating copy to clipboard operation
sof copied to clipboard

build: namespace the generated `version.h` - take 2

Open ycsin opened this issue 2 years ago • 3 comments

Zephyr's build time generated version.h is now in the zephyr to provide proper namespace, update the includes of this module accordingly.

See ZephyrProject upstream PR at: https://github.com/zephyrproject-rtos/zephyr/pull/63973

Take 1: #8459

ycsin avatar Nov 20 '23 17:11 ycsin

Can one of the admins verify this patch?

reply test this please to run this test once

sofci avatar Nov 20 '23 17:11 sofci

@ycsin So can you get the Zephyr thing merged by reopening https://github.com/zephyrproject-rtos/sof/pull/31 and use that in Zephyr west.yml, and when we update SOF to new Zephyr, we'll merged this PR as part of the west.yml update. I think that's what @marc-hb wanted , and this, too, is ok for me. If Zephyr maintainers ask, you can point to this comment.

kv2019i avatar Nov 21 '23 16:11 kv2019i

I can see this is now targetting Zephyr 3.7.0 , so let's bum the SOF milestone target appropriately to 2.10.

kv2019i avatar Mar 04 '24 13:03 kv2019i