sof icon indicating copy to clipboard operation
sof copied to clipboard

topology2: cavs-nocodec: Add an intermediate pipeline

Open ranj063 opened this issue 3 years ago • 5 comments

Add an intermediate pipeline between the host and DAI pipelines.

Signed-off-by: Ranjani Sridharan [email protected]

ranj063 avatar Oct 11 '22 21:10 ranj063

this is how the new tplg looks now. tplg

ranj063 avatar Oct 11 '22 23:10 ranj063

does the mixout->gain->mixin pipeline have to be present only in playback? I think it is also possible in a capture pipeline.

aiChaoSONG avatar Oct 12 '22 01:10 aiChaoSONG

does the mixout->gain->mixin pipeline have to be present only in playback? I think it is also possible in a capture pipeline.

maybe but I guess for a test for intermediate pipelines, this is good enough

ranj063 avatar Oct 12 '22 02:10 ranj063

SOFCI TEST

miRoox avatar Oct 14 '22 01:10 miRoox

Almost 100% failure rate in Intel IPC4 plan, see test run 16208 . UPDATE: this can be unrelated as I see FW load failing, but needs to be confirmed.

I guess it is because this PR should be tested with the intermediate pipeline kernel support https://github.com/thesofproject/linux/pull/3917

aiChaoSONG avatar Oct 14 '22 02:10 aiChaoSONG

Almost 100% failure rate in Intel IPC4 plan, see test run 16208 . UPDATE: this can be unrelated as I see FW load failing, but needs to be confirmed.

I guess it is because this PR should be tested with the intermediate pipeline kernel support thesofproject/linux#3917

@aiChaoSONG @kv2019i any update ? Can we merge ?

lgirdwood avatar Oct 19 '22 14:10 lgirdwood

@ranj063 looks like we have a conflict now.

@lgirdwood this will have to wait until we bring back the mixer to the nocodec tplg. We're very close to doing that. Please hold off on merging this for a couple more days

ranj063 avatar Oct 19 '22 15:10 ranj063

@ranj063 looks like we have a conflict now.

@lgirdwood this will have to wait until we bring back the mixer to the nocodec tplg. We're very close to doing that. Please hold off on merging this for a couple more days

ok, pls ping me when ready.

lgirdwood avatar Oct 24 '22 10:10 lgirdwood

how is this related to #6131 ? EDIT: ok, that one is topology1, sorry, ignore this

lyakh avatar Oct 26 '22 10:10 lyakh

the goal is the same @lyakh, for both topology1 and 2 we want to catch invalid firmware assumptions that a pipeline is connected to a dai or a host, and in the case of IPC4 detect cases where the intermediate pipeline is not correctly configured by the Linux driver. Think of the nocodec topology as a 'pipe cleaner'

plbossart avatar Oct 26 '22 22:10 plbossart

@ranj063 array-support merged in #7113 so rebase will be needed

kv2019i avatar Feb 17 '23 07:02 kv2019i

@ranj063 array-support merged in #7113 so rebase will be needed

@kv2019i wouldn't this be dropped in favour of #6981 or do we need both stream types in nocodec?

lyakh avatar Feb 17 '23 09:02 lyakh