sof icon indicating copy to clipboard operation
sof copied to clipboard

[SKIP CI] .github: extract standalone testbench.yml from Main Actions

Open marc-hb opened this issue 2 years ago • 6 comments

Among other benefits this will make it possible to enable and disable testbench from the Github web interface:

https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow

Signed-off-by: Marc Herbert [email protected]

marc-hb avatar Sep 07 '22 22:09 marc-hb

Wow, the newly separated testbench workflow has finished running and completed just fine (see results in https://github.com/thesofproject/sof/runs/8238590042 , https://github.com/thesofproject/sof/runs/8238871857) BUT the summary window is stuck, still waiting for its results to come!?

This summary corruption could be related to the "gcc-build-only (sue jsl tgl)" phantom check issue #6241 reported in https://support.github.com/ticket/personal/0/1772548

Screenshot 2022-09-07 at 15 50 44

marc-hb avatar Sep 07 '22 22:09 marc-hb

Maybe this could help understand the bug:

  • https://docs.github.com/en/rest/checks/suites
  • https://docs.github.com/en/rest/commits/statuses

marc-hb avatar Sep 08 '22 00:09 marc-hb

This is ready to be merged.

Problem found and solved, this was all caused by main branch protection rules in https://github.com/thesofproject/sof/settings/branches (which I do not have access to, only admins do)

Removing the protection rules made the problem instantly go away on all affected PRs (no need to force push or anything).

marc-hb avatar Sep 14 '22 21:09 marc-hb

This is ready to be merged.

Problem found and solved, this was all caused by main branch protection rules in https://github.com/thesofproject/sof/settings/branches (which I do not have access to, only admins do)

Removing the protection rules made the problem instantly go away on all affected PRs (no need to force push or anything).

Thanks - this might not be needed. I may have a way forward as so far changes are not as invasive as originally expected.

lgirdwood avatar Sep 15 '22 12:09 lgirdwood

Good news!

This extraction / separation is a Good Thing even if the current testbench stays enabled forever.

marc-hb avatar Sep 15 '22 14:09 marc-hb

Unrelated MTL failures in https://github.com/thesofproject/sof/actions/runs/3277832496/jobs/5395553969 introduced by #6360, fixed submitted in #6439

marc-hb avatar Oct 19 '22 00:10 marc-hb