sof
sof copied to clipboard
thesofproject
Intel Meteorlake platform upstream
@piotrkmx what do we do with 9ef052f30b69ae517b8f80e72b2d2514878c2d0a? Remove? Leave? @marcinszkudlinski do we leave any bug tracking references in commits like in ae38b5d5a36218d738ad052547666a5cfb026a35? Looks like we can't since it points to completely different issue...
This configuration still support non-zephyr build? I think for MTL we want to support only Zephyr option and all this ace platform&drivers stuff should not be upstreamed
@piotrkmx what do we do with 9ef052f? Remove? Leave?
In current form this will break previous platforms
@aborisovich can this PR be split into per topic PRs e.g for ssp, dmic, dma, pm etc ? This way should be easier to review and upstream. Thanks.
Please don't. It will be only easier to review but not to upstream. The only measurement we have that whether upstream is complete and working after all refactors during review is building a firmware and run tests to confirm that results are similar to innersource test results. If we split this upstream to multiple PRs there is no way to perform tests and fairly compare them. Number of files will be reduced as MTL platform will have only Zephyr build (I'm removing code parts related to building with SOF XTOS). @marc-hb how can I remove MTL platform from building in "Reproducible builds / main (pull_request)" CI?
@aborisovich can this PR be split into per topic PRs e.g for ssp, dmic, dma, pm etc ? This way should be easier to review and upstream. Thanks.
As soon as I will remove SOF XTOS content from upstream I will try to sort it better,
The only measurement we have that whether upstream is complete and working after all refactors during review is building a firmware and run tests to confirm that results are similar to innersource test results. If we split this upstream to multiple PRs there is no way to perform tests and fairly compare them.
That's what all other open-source programs programs do, including the Linux kernel. You can perfectly submit smaller PRs and rebase your internal code on the smaller merges. Doing one big merge from one branch to the other is really not encouraged.
As soon as I will remove SOF XTOS content from upstream I will try to sort it better,
Please also remove any IP programming code as this belongs in Zephyr, e.g. I can see a header for register definitions (which I think we already have upstream in Zephyr alongside drivers).
@marc-hb how can I remove MTL platform from building in "Reproducible builds / main (pull_request)" CI?
"Reproducible builds" is XTOS only, no Zephyr and no MTL build. This failed because you changed code (also?) used by XTOS.
EDIT: I think @abonislawski said something similar 2 days ago.
As soon as I will remove SOF XTOS content from upstream
OK
