sof icon indicating copy to clipboard operation
sof copied to clipboard

Why do topologies have generic names?

Open psykana opened this issue 2 years ago • 2 comments

Take a look at this commit, for example: https://github.com/thesofproject/sof/pull/5974/files The only thing that indicates that this tolopogy is for an HP Omen 16 device is the commit message. This goes for pretty much for the entire library of SOF topologies. As someone who's just getting into SOF, I am really surprised that finding what runs on your machine appears to require some sacred knowledge. IMO, OEMs or whoever submits PR's with device-specific topologies, should name them accordingly. Please tell me what's the reasoning behind this and if I'm missing something here. Thanks.

psykana avatar Jul 17 '22 11:07 psykana

@psykana the main reason it to reduce maintenaning multiple topology files and promote reuse. The topology file associate with a machine is associated with the platform, the DAI's on the platform and the codecs on a device rather than the device name itself. There could be several devices out there with the same set of DAI's/codecs for the same platform. It is unrealistic to maintain a separate topology file for each of those devices out there. Hope this helps

ranj063 avatar Jul 17 '22 18:07 ranj063

@psykana there's nothing 'sacred' here, what we try to do in the Linux driver is to find at boot time from the hardware, PCI and ACPI subsystem what the platform is. It's not different from what is done in other part of the Linux sound subsystem. We typically don't use commercial names unless we have no alternative, the DMI quirks that were introduced for the HP Omen 16 are the last-resort to fix a broken BIOS, not the baseline.

plbossart avatar Jul 18 '22 19:07 plbossart