sof icon indicating copy to clipboard operation
sof copied to clipboard

[TESTING] tplg parser refactoring to support other IPC versions

Open lgirdwood opened this issue 3 years ago • 1 comments

Continue with tplg parser and testbench refactoring to support multiple IPC versions.

lgirdwood avatar Jul 14 '22 11:07 lgirdwood

@fredoh9 @marc-hb @greg-intel do the CI containers carry the alsa-lib kernel ABI headers ?

-- Build files have been written to: /home/runner/work/sof/sof/tools/testbench/build_testbench/sof_parser/build
[ 52%] Performing build step for 'parser_ep'
[  7%] Building C object CMakeFiles/sof_tplg_parser.dir/tokens.c.o
-- Found Python3: /usr/bin/python3.8 (found version "3.8.10") found components: Interpreter 
-- The C compiler identification is GNU 9.4.0
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/cc
-- Detecting C compiler ABI info
In file included from /home/runner/work/sof/sof/tools/tplg_parser/tokens.c:19:
/home/runner/work/sof/sof/tools/tplg_parser/include/tplg_parser/tokens.h:21:10: fatal error: alsa/sound/uapi/asoc.h: No such file or directory
   21 | #include <alsa/sound/uapi/asoc.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[5]: *** [CMakeFiles/sof_tplg_parser.dir/build.make:76: CMakeFiles/sof_tplg_parser.dir/tokens.c.o] Error 1
make[4]: *** [CMakeFiles/Makefile2:83: CMakeFiles/sof_tplg_parser.dir/all] Error 2
make[3]: *** [Makefile:136: all] Error 2
make[2]: *** [CMakeFiles/parser_ep.dir/build.make:86: sof_parser/src/parser_ep-stamp/parser_ep-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:1[40](https://github.com/thesofproject/sof/runs/7931859525?check_suite_focus=true#step:6:41): CMakeFiles/parser_ep.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

EDIT: example https://github.com/thesofproject/sof/runs/8003304805

lgirdwood avatar Aug 20 '22 13:08 lgirdwood

I have no idea sorry. @juimonen and/or @fredoh9 should know.

You can explore the image interactively with a simple sof/scripts/docker-run.sh /bin/bash

The list of packages in the docker image is here: https://github.com/thesofproject/sof/tree/main/scripts/docker_build/sof_builder

marc-hb avatar Aug 21 '22 21:08 marc-hb

Container has the headers

sof@f7a3cfc83173:~/work/sof.git$ ls -l /usr/include/alsa/sound/uapi/asoc.h 
-rw-r--r-- 1 root root 22550 Jun  6 15:22 /usr/include/alsa/sound/uapi/asoc.h

and I can locally build in my container. @fredoh9 any idea why CI container failed ?

lgirdwood avatar Aug 22 '22 12:08 lgirdwood

@fredoh9 for info Ubuntu docker is using the overlay FS by default.

docker info
Client:
 Context:    default
 Debug Mode: false
 Plugins:
  app: Docker App (Docker Inc., v0.9.1-beta3)
  buildx: Build with BuildKit (Docker Inc., v0.5.1-docker)

Server:
 Containers: 8
  Running: 3
  Paused: 0
  Stopped: 5
 Images: 5
 Server Version: 20.10.2
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Native Overlay Diff: true

Can you check the CI container for asoc.h header ?

lgirdwood avatar Aug 25 '22 09:08 lgirdwood

Mystery solved, the testbench is NOT built inside the container right now: https://github.com/thesofproject/sof/blob/141efbd7b0e924/.github/workflows/pull-request.yml#L120

Until now there was no need to use the container.

Let me look into the various options.

marc-hb avatar Aug 25 '22 09:08 marc-hb

  • #6188 should fix it

marc-hb avatar Aug 25 '22 09:08 marc-hb

After merging #6188 (thx!) https://github.com/thesofproject/sof/runs/8015585901 is now failing with a "real" issue found by valgrind

marc-hb avatar Aug 25 '22 13:08 marc-hb

@wszypelt @lrudyX not sure why CI is reporting failure, this PR is for testbench only, so it should not impact the FW ?

lgirdwood avatar Aug 29 '22 08:08 lgirdwood

Jenkins not run. Rerun CI.

lgirdwood avatar Aug 29 '22 08:08 lgirdwood

SOFCI TEST

lgirdwood avatar Aug 29 '22 08:08 lgirdwood

@lgirdwood The problem is on the side of our machine, I have already clicked rerun and it is in the queue for execution, I think within an hour, it will be green.

wszypelt avatar Aug 29 '22 08:08 wszypelt

@lgirdwood There were still some difficulties, I hope you will get results within 30 minutes

wszypelt avatar Aug 29 '22 10:08 wszypelt