sof icon indicating copy to clipboard operation
sof copied to clipboard

[To Be Dropped][Disregard] legacy: disable pause / release on CHT, BYT, BDW and HSW

Open lyakh opened this issue 2 years ago • 5 comments

Legacy platforms have insufficient resources to reliably handle stream pausing, and it isn't used by audio servers anyway, so it can be safely disabled on them.

lyakh avatar May 27 '22 07:05 lyakh

CI: as expected, pause-resume tests now fail on BYT https://sof-ci.01.org/sofpr/PR5861/build498/devicetest/?model=BYT_MB_NOCODEC&testcase=check-pause-resume-playback-10

lyakh avatar May 27 '22 08:05 lyakh

CI: as expected, pause-resume tests now fail on BYT https://sof-ci.01.org/sofpr/PR5861/build498/devicetest/?model=BYT_MB_NOCODEC&testcase=check-pause-resume-playback-10

I was chatting last night to @ranj063 about this and I think it may be better if we convert IPC_PAUSE to STOP and IPC_RELEASE to START in the IPC layer. This would mean userspace would see no error when it tries to PAUSE. Can you give this a try, would be interested to see the CI here.

lgirdwood avatar May 27 '22 10:05 lgirdwood

That's interesting why this would fail for STOP and START. Does this change fail on newer HW too like TGL ? Maybe we have a race ?

lgirdwood avatar May 30 '22 08:05 lgirdwood

That's interesting why this would fail for STOP and START. Does this change fail on newer HW too like TGL ? Maybe we have a race ?

@lgirdwood you mean why it's failing pause-release tests so early - before even starting to stream? Yeah, I'm surprised too. No logs at all https://sof-ci.01.org/sofpr/PR5861/build504/devicetest/?model=BYT_MB_NOCODEC&testcase=check-pause-resume-playback-10, at least kernel logs should be there

lyakh avatar May 30 '22 10:05 lyakh

CI: BYT reported a timeout with this PR with all pause-release tests: https://sof-ci.01.org/sofpr/PR5861/build504/devicetest/?model=BYT_MB_NOCODEC&testcase=check-pause-resume-playback-10 and one of the reasons for this PR was #5836 . BYT is now in maintenance mode, but I'm not sure if we should merge something that was explicitly trying to fix a problem on BYT and instead is supposedly only making it worse

lyakh avatar Jun 22 '22 06:06 lyakh

No activity in a long time, converting as draft.

kv2019i avatar Dec 16 '22 11:12 kv2019i