sof icon indicating copy to clipboard operation
sof copied to clipboard

Posting wrapper code draft for Sound Research post-processing library

Open EdwardAbramian2-SR opened this issue 3 years ago • 9 comments

This is the initial wrapper code draft of Sound Research post-processing library.

EdwardAbramian2-SR avatar Apr 16 '22 01:04 EdwardAbramian2-SR

Can one of the admins verify this patch?

reply test this please to run this test once

sofci avatar Apr 16 '22 01:04 sofci

Can one of the admins verify this patch?

sys-pt1s avatar Apr 16 '22 02:04 sys-pt1s

@EdwardAbramian2-SR The code doesn't build. I created a minimal kconfig and added sr_audio to CmakeLists.txt. I will try the block audio stream functions (to replace the read/write frag functions) with some other component.

singalsu avatar Apr 26 '22 08:04 singalsu

@EdwardAbramian2-SR can you try to see if codec_adapter / module interface is usable with your API? See src/audio/codec_adapter/

dbaluta avatar Apr 26 '22 10:04 dbaluta

@singalsu

We have no problem building our code under tgl-013-drop-stable branch, assuming our SOF_COMP_SRAUDIO is defined in topology (see the attached build log). We used that branch to compile for ASUS test unit before the target test units were available. We haven't yet attempted to build with adl-004-drop-stable branch.

build_log.txt

EdwardAbramian2-SR avatar Apr 27 '22 01:04 EdwardAbramian2-SR

@EdwardAbramian2-SR pls check your email - I've sent invite meaning future PRs will auto run the CI for you.

lgirdwood avatar Apr 27 '22 10:04 lgirdwood

@singalsu

We have no problem building our code under tgl-013-drop-stable branch, assuming our SOF_COMP_SRAUDIO is defined in topology (see the attached build log). We used that branch to compile for ASUS test unit before the target test units were available. We haven't yet attempted to build with adl-004-drop-stable branch.

build_log.txt

Yep, sr_audio seems to build OK in the log. I used main branch and own additions to kconfig and cmake, so likely my bad.

We no more use SOF_COMP_X for new development. Instead all audio processing goes to process type with generic basic IPC where only UUID identifies them. TDFB is one example of such component.

singalsu avatar Apr 27 '22 10:04 singalsu

@EdwardAbramian2-SR initial build should be for ToT (main) then when you backport you make your changes functional for the target branches

cujomalainey avatar Apr 27 '22 17:04 cujomalainey

@EdwardAbramian2-SR ping, do you have an ETA ? Merge window is fully open now for v2.3

lgirdwood avatar Jul 07 '22 11:07 lgirdwood

No response in >1Q, closing

cujomalainey avatar Aug 23 '22 00:08 cujomalainey