sof icon indicating copy to clipboard operation
sof copied to clipboard

audio: remove all redundant list init's

Open ranj063 opened this issue 3 years ago • 10 comments

comp_new() for both IPC3 and IPC4 initializes the source/sink buffer lists already. So, remove the redundant init from the component create callbacks.

Signed-off-by: Ranjani Sridharan [email protected]

ranj063 avatar Apr 07 '22 00:04 ranj063

oh man, that should have been caught by coverity.

dbaluta avatar Apr 07 '22 08:04 dbaluta

@kkarask will rerun CI again as the logs are timing out for 2 failed tests.

lgirdwood avatar Apr 07 '22 12:04 lgirdwood

SOFCI TEST

lgirdwood avatar Apr 07 '22 12:04 lgirdwood

@kkarask @wszypelt fwiw, looks like we have some test failures but the logs wont display. See https://sof-ci.01.org/sof-pr-viewer/#/build/PR5655/build9042903

lgirdwood avatar Apr 08 '22 09:04 lgirdwood

@lgirdwood Yes, we have noticed that. In order to collect logs for IPC4 tests there is a need to change test code and adjust it to internal services. Work in progress.

kkarask avatar Apr 08 '22 10:04 kkarask

@kkarask ok, thanks - pls ping us when it's back working and we ca rerun this one (and any others)

lgirdwood avatar Apr 11 '22 19:04 lgirdwood

Can one of the admins verify this patch?

sys-pt1s avatar Apr 15 '22 11:04 sys-pt1s

SOFCI TEST

lgirdwood avatar Apr 19 '22 10:04 lgirdwood

@wszypelt the CI result is still not loading the logs for failed tests. Can you check ? Thanks !

lgirdwood avatar Apr 19 '22 15:04 lgirdwood

@ranj063 ping

lgirdwood avatar Jul 07 '22 11:07 lgirdwood

No activity in a long time, converting as draft.

kv2019i avatar Dec 16 '22 11:12 kv2019i