sof icon indicating copy to clipboard operation
sof copied to clipboard

Create topology for I2S ALC5682 and ALC1019

Open udaymb opened this issue 3 years ago • 14 comments

Topology to support ALC5682 and ALC1019 codec

udaymb avatar Jan 11 '22 13:01 udaymb

@udaymb Please put the conf file in the tools/topology/topology2/cavs/ folder.

bardliao avatar Jan 12 '22 00:01 bardliao

As suggested moved to tools/topology/topology2/cavs/cavs-rt5682-rt1019.conf

udaymb avatar Jan 12 '22 09:01 udaymb

@ranj063 not seeing you on the review, can you add yourself to CODEOWNERS for topology2 ?

lgirdwood avatar Jan 12 '22 14:01 lgirdwood

Pls also make sure the DAI link id matches with machine driver, spk link is created after DMIC in sof_rt5682.c.

DAI link ids are updated as per the machine driver

Should we leave formats field to default? otherwise it can only play S32_LE.

Removed the entries to use the default

udaymb avatar Jan 21 '22 11:01 udaymb

After discussion, moved to passthrough instead of volume playback/capture

udaymb avatar Jan 21 '22 11:01 udaymb

The id is unique, since SSP0's id is 1, so DMIC id cannot be 1 again. Done

A more friendly name than PortN? Done

udaymb avatar Jan 24 '22 06:01 udaymb

@udaymb Please add "cavs-rt5682-rt1019;cavs-rt5682-rt1019.conf" into tools/topology/topology2/cavs/CMakeLists.txt so that we can build this topology with ./scripts/build-tools.sh

bardliao avatar Jan 24 '22 09:01 bardliao

@udaymb Please add "cavs-rt5682-rt1019;cavs-rt5682-rt1019.conf" into tools/topology/topology2/cavs/CMakeLists.txt so that we can build this topology with ./scripts/build-tools.sh Added it in CMakeLists.txt

https://github.com/thesofproject/sof/pull/5231#commitcomment-64270686 Based on this PRs comment, removed dai_index to inherit from parent DAI object

udaymb avatar Jan 27 '22 14:01 udaymb

https://github.com/thesofproject/sof/pull/5187#discussion_r792989721 this is modified now

https://github.com/thesofproject/sof/pull/5187#discussion_r792989135 modified

Setting these values for ALC5682 - SSP0

MCLK 19.2MHz DAI_CONFIG(SSP, 0, 0, SSP0-Codec, SSP_CONFIG(I2S, SSP_CLOCK(mclk, 19200000, codec_mclk_in), SSP_CLOCK(bclk, 2400000, codec_slave), SSP_CLOCK(fsync, 48000, codec_slave), SSP_TDM(2, 25, 3, 3), SSP_CONFIG_DATA(SSP, 0, 24, 0, 0, 0, SSP_CC_BCLK_ES)))

Setting these values for ALC1019 - SSP1

MCLK 19.2MHz SSP_CONFIG(I2S, SSP_CLOCK(mclk, 19200000, codec_mclk_in), SSP_CLOCK(bclk, 3072000, codec_slave), SSP_CLOCK(fsync, 48000, codec_slave), SSP_TDM(2, 32, 3, 3), SSP_CONFIG_DATA(SSP, 1, 24))

udaymb avatar Jan 27 '22 14:01 udaymb

https://github.com/thesofproject/sof/pull/5187#discussion_r793757912

Updating all settings similar to rt1011 https://github.com/thesofproject/sof/blob/main/tools/topology/topology1/sof-tgl-max98357a-rt5682.m4#L380-L385

udaymb avatar Feb 01 '22 17:02 udaymb

Can one of the admins verify this patch?

sys-pt1s avatar Apr 20 '22 06:04 sys-pt1s

@udaymb ping ?

lgirdwood avatar Apr 20 '22 18:04 lgirdwood

Apologies for the delay - board is still not available for verification Need to wait till get it

udaymb avatar May 09 '22 17:05 udaymb

@udaymb I'm turning this to a draft as this is stuck on hw availability.

kv2019i avatar Oct 13 '22 09:10 kv2019i

Stale PR,closing

kv2019i avatar Mar 04 '24 13:03 kv2019i