sof icon indicating copy to clipboard operation
sof copied to clipboard

[BUG] Component tuning and audio test scripts do not work with topology2

Open singalsu opened this issue 4 years ago • 1 comments

Describe the bug

The Matlab language scripts in tools/tune and tools/test/audio directories do not work with topology2.

To Reproduce Create configuration blob for component or run audio_process_test().

Reproduction Rate

Expected behavior Similar as with topology1

Impact Showstopper for doing new component setup blobs with topology2. Only minimal configuration blobs set for builds needs has been ported.

Environment

  1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
    • Kernel: {SHA}
    • SOF: {SHA}
  2. Name of the topology file
    • Topology: {FILE}
  3. Name of the platform(s) on which the bug is observed.
    • Platform: {PLATFORM}

Screenshots or console output If applicable, add a screenshot (drag-and-drop an image), or console logs (cut-and-paste text and put a code fence (```) before and after, to help explain the issue.

Please also include the relevant sections from the firmware log and kernel log in the report (and attach the full logs for complete reference). Kernel log is taken from dmesg and firmware log from sof-logger. See https://thesofproject.github.io/latest/developer_guides/debugability/logger/index.html

singalsu avatar Jul 21 '21 11:07 singalsu

There's work in progress PR in #5603. It depends on #5306 also.

singalsu avatar May 13 '22 08:05 singalsu

IIR and FIR changes are merged. TDFB, and MFCC are remaining.

singalsu avatar Feb 22 '23 11:02 singalsu

@singalsu Still on track for V2.5 -- we aim to branch this week?

kv2019i avatar Mar 06 '23 10:03 kv2019i

TDFB and MFCC won't make it to v2.5. We don't have in IPC4 the controls framework for TDFB (enum, switch). They are missing also from module adapter, so quite a lot work. In MFCC I have not yet figured out use of compressed stream.

singalsu avatar Mar 06 '23 15:03 singalsu

@singalsu on track for v2.6 ? or should be moved to v2.7 ?

lgirdwood avatar May 10 '23 21:05 lgirdwood

@lgirdwood Thanks, I moved to v2.7. We still have many components without IPC4 support, so even if changing the tools and blobs could happen before start of June, we can't test them. One more month looks possible.

singalsu avatar May 15 '23 10:05 singalsu

@singalsu any update ? how are we trending ?

lgirdwood avatar Jul 04 '23 16:07 lgirdwood

@singalsu any update ? how are we trending ?

I've been doing these updates the same time with module API conversions and creating topologies to test them. DC blocker is still without a PR or draft PR. I plan to do it after the crossover and multi-band drc conversions. It's fortunately much smaller effort than these two. One month ETA for all work merged?

singalsu avatar Jul 25 '23 14:07 singalsu

@singalsu , how have things progressed? Would like to move to 2.8 if remaining effort will take longer than a week.

alex-cri avatar Aug 21 '23 22:08 alex-cri

@singalsu , is there an update?

alex-cri avatar Sep 06 '23 02:09 alex-cri

@singalsu , is there an update?

I think all non-deprecated (*) components have a module adapter and ipc4 PR done. But some are still not yet merged. We miss tplg2 support PRs still for some. The enum control that worked with tplg1 is not yet solved for tplg2. It's however used only by one component (beamformer) that has not been included to signed FW builds.

So all the work (tplg2 support) won't be completed in week so we can move on to 2.8.

(*) We will deprecate now tone generator and selector - turn kconfig off and have warning if enabled.

singalsu avatar Sep 06 '23 15:09 singalsu

All components those have setup script for topology1 now have setup scripts for topology2. This can be closed now!

singalsu avatar Oct 16 '23 07:10 singalsu