thesofproject
[FEATURE] Update and remove passthrough definitions
some components have outdated manual copy code, we need to clean these up with the new audio_stream_copy function.
Current spotted ones are:
- Crossover This works because the definition of
audio_stream_copydoes not include updating the buffer r/w - IGO NR module not entirely necessary, just would allow a bypass of the whole interleave/deinterleave logic
I will need to see if there are any others but a quick search for "passthrough" yielded the above results.
@cujomalainey @johnylin76 @fuyuntsuo Cleaning up our milestone 1.9 leftovers and this got picked in the filter. It seems this would be still valid. I'll bump it to v2.6 for now.
@andrula-song @singalsu I assume all modules now using optimal copy/processing API/loops now. Can we close ?
@lgirdwood The crossover and igo_nr are still using the read/write frag function in a MCPS expensive way. We will convert both to module adapter in this Q2 that will address this issue too.
@singalsu @andrula-song any update, I guess most modules now optimized, can we close ?
checked the code, igo_nr still not converted to module_adapter interface. I am afraid we can not close it now.
Thanks @andrula-song . For IGO_NR we have a draft for module conversion, but that won't make it to v2.8, so let me that that PR for v2.9 and push feature as well. Draft at https://github.com/thesofproject/sof/pull/8301
@andrula-song @singalsu IGO_NR is now converted to module interface, #8301 is merged as well. Can we close?
@kv2019i IGO_NR is now OK, but crossover isn't. The module conversion is done but there was no need to touch the processing core functions. It would be a separate work item from us.
