sof icon indicating copy to clipboard operation
sof copied to clipboard

audio: copier: Refactor deep copy of copier config

Open wjablon1 opened this issue 3 weeks ago • 3 comments

Code for copying copier_data is ambiguous. A comment suggests that the deep copy (data structure + variable-length array) is not needed but the copy of variable-length array is performed afterwards. This change rectifies this by placing ipc4_copier_module_cfg at the end of copier_data structure as it contains a variable-length array. This enables single memory allocation and single, clean 1:1 copy for the complete copier_data with the variable-length addition.

wjablon1 avatar Dec 15 '25 16:12 wjablon1

Can one of the admins verify this patch?

reply test this please to run this test once

sofci avatar Dec 15 '25 16:12 sofci

SOFCI TEST

tmleman avatar Dec 17 '25 08:12 tmleman

@wjablon1 there is some red on the CI, can you check. Thanks !

lgirdwood avatar Dec 17 '25 16:12 lgirdwood

Jenkins stuck, restart it.

lgirdwood avatar Dec 19 '25 12:12 lgirdwood

SOFCI TEST

lgirdwood avatar Dec 19 '25 12:12 lgirdwood