sof icon indicating copy to clipboard operation
sof copied to clipboard

modules: Apparently asking 0 alignment is dangerous, use 4 as default

Open jsarha opened this issue 2 months ago • 5 comments

The current rballoc_align() implementation has this line: assert(IS_ALIGNED(mem, align));

Which will cause division by zero due to IS_ALIGNED() Zephyr implementation: define IS_ALIGNED(ptr, align) (((uintptr_t)(ptr)) % (align) == 0)

So better use 4 as the default value.

jsarha avatar Oct 23 '25 10:10 jsarha

@lrudyX can you check quickbuild? Both me and Jyri checked the logs and doesn't seem related to this PR. There are no failures in FW log, but TestBasicHdaLinkRandomDma test is reported as timed out. The IPC log doesn't show any IPC timing out, so not sure what goes wrong. FYI @jsarha

kv2019i avatar Oct 24 '25 11:10 kv2019i

@lrudyX can you check quickbuild? Both me and Jyri checked the logs and doesn't seem related to this PR. There are no failures in FW log, but TestBasicHdaLinkRandomDma test is reported as timed out. The IPC log doesn't show any IPC timing out, so not sure what goes wrong. FYI @jsarha

No, this is sporadic problem seen in many others PR

lrudyX avatar Oct 24 '25 11:10 lrudyX

@lrudyX can you check quickbuild? Both me and Jyri checked the logs and doesn't seem related to this PR. There are no failures in FW log, but TestBasicHdaLinkRandomDma test is reported as timed out. The IPC log doesn't show any IPC timing out, so not sure what goes wrong. FYI @jsarha

No, this is sporadic problem seen in many others PR

Can we rerun @lrudyX ? thanks.

lgirdwood avatar Oct 24 '25 12:10 lgirdwood

@lrudyX can you check quickbuild? Both me and Jyri checked the logs and doesn't seem related to this PR. There are no failures in FW log, but TestBasicHdaLinkRandomDma test is reported as timed out. The IPC log doesn't show any IPC timing out, so not sure what goes wrong. FYI @jsarha

No, this is sporadic problem seen in many others PR

Can we rerun @lrudyX ? thanks. We have DUT problem at the moment, I will rerun as soon as possible.

lrudyX avatar Oct 27 '25 12:10 lrudyX

Ok, here is an alternative solution. We need one or the other, preferrably soon. So please agree on either one (I would still vote for both). https://github.com/thesofproject/sof/pull/10345

jsarha avatar Oct 31 '25 10:10 jsarha