sof icon indicating copy to clipboard operation
sof copied to clipboard

Code to decode pipeline create messages payload

Open jsarha opened this issue 3 months ago • 8 comments

Code to decode pipline create messages payload. E.g. this code is written to test this PR: https://github.com/thesofproject/linux/pull/5537

jsarha avatar Sep 26 '25 11:09 jsarha

@lgirdwood this is now updated so that it should be almost exact match to https://github.com/thesofproject/sof/pull/10281 , vpages code only needs to use the params passed to pipeline_new(). But to use this the topology should be built from this PR and you need my linux driver PR https://github.com/thesofproject/sof/pull/10281 too to pass down the topology info.

jsarha avatar Dec 03 '25 19:12 jsarha

This version address the changes requested to https://github.com/thesofproject/linux/pull/5537 . I still need to move the module init payload decoding to happen already before module_adapter_mem_alloc() -call, before this is ready.

jsarha avatar Dec 14 '25 23:12 jsarha

Finaly the module init payload decoding is happening where it should be. Ready for review.

jsarha avatar Dec 16 '25 16:12 jsarha

@lgirdwood should I rebase this or is it better to keep it on top of older base still?

jsarha avatar Dec 16 '25 16:12 jsarha

@lgirdwood should I rebase this or is it better to keep it on top of older base still?

Best to rebase and adding @ranj063

lgirdwood avatar Dec 16 '25 16:12 lgirdwood

Fixed copilot spotted typos.

jsarha avatar Dec 16 '25 21:12 jsarha

... and rebased.

jsarha avatar Dec 16 '25 22:12 jsarha

I am bit surprised that that castiing a const pointer to non const integer pointer does not cause a warning

@jsarha I think that's exactly how it's designed - the compiler respects the explicit cast and relies on the coder knowing what they're doing. Without a cast it would warn. Then there's a bunch of compiler flags to modify that "naive default" of which I certainly don't know all.

lyakh avatar Dec 17 '25 15:12 lyakh

Tobe squashed commits squashed.

jsarha avatar Dec 18 '25 20:12 jsarha