linux icon indicating copy to clipboard operation
linux copied to clipboard

ASoC: Intel: soc-acpi-intel-ptl-match: add rt712_vb_l3_rt1320_l2 and rt713_vb_l3_rt1320_l12 support

Open ujfalusi opened this issue 11 months ago • 12 comments

Add rt712_vb on SDW link 3 and 1 rt1320 on SDW link 2 configuration support.

ujfalusi avatar Jan 31 '25 09:01 ujfalusi

Changes since v1:

  • use group1 for rt1320

ujfalusi avatar Feb 03 '25 08:02 ujfalusi

Changes since v2:

  • add spk_r_endpoint for rt1320

ujfalusi avatar Feb 03 '25 08:02 ujfalusi

Changes since v2:

  • Addresses should use capital letters in hex numbers
  • corrected rt1320 address to production version
  • added new config for rt713-l3 with rt3120-l12

ujfalusi avatar Feb 06 '25 07:02 ujfalusi

Changes since v3:

  • Fix commit message for rt713_l3-rt1320_l12

ujfalusi avatar Feb 10 '25 09:02 ujfalusi

Not sure what happened to the LNL SDW test https://sof-ci.01.org/linuxpr/PR5315/build6111/devicetest/index.html. Let rerun the test.

bardliao avatar Feb 14 '25 02:02 bardliao

SOFCI TEST

bardliao avatar Feb 14 '25 02:02 bardliao

Not sure what happened to the LNL SDW test https://sof-ci.01.org/linuxpr/PR5315/build6111/devicetest/index.html. Let rerun the test.

This seems unrelated to PTL, but could we be including a shared topology file that breaks ?

2025-02-14 02:44:01 UTC [ERROR] Caught kernel log error
===========================>>
[    5.740282] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: error: can't connect DAI alh-copier.SDW2-Playback.0 stream SDW2-Playback
[    5.740285] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: failed to add widget type 27 name : alh-copier.SDW2-Playback.0 stream SDW2-Playback
[    5.740294] kernel: sof_sdw sof_sdw: ASoC: failed to load widget alh-copier.SDW2-Playback.0
[    5.740297] kernel: sof_sdw sof_sdw: ASoC: topology: could not load header: -22
[    5.740353] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: error: tplg component load failed -22
[    5.740362] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: error: failed to load DSP topology -22
[    5.740365] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: ASoC: error at snd_soc_component_probe on 0000:00:1f.3: -22
[    5.740407] kernel: sof_sdw sof_sdw: ASoC: failed to instantiate card -22
[    5.740863] kernel: sof_sdw sof_sdw: error -EINVAL: snd_soc_register_card failed -22
[    5.740869] kernel: sof_sdw sof_sdw: probe with driver sof_sdw failed with error -22

lgirdwood avatar Feb 14 '25 11:02 lgirdwood

Not sure what happened to the LNL SDW test https://sof-ci.01.org/linuxpr/PR5315/build6111/devicetest/index.html. Let rerun the test.

This seems unrelated to PTL, but could we be including a shared topology file that breaks ?

2025-02-14 02:44:01 UTC [ERROR] Caught kernel log error
===========================>>
[    5.740282] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: error: can't connect DAI alh-copier.SDW2-Playback.0 stream SDW2-Playback
[    5.740285] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: failed to add widget type 27 name : alh-copier.SDW2-Playback.0 stream SDW2-Playback
[    5.740294] kernel: sof_sdw sof_sdw: ASoC: failed to load widget alh-copier.SDW2-Playback.0
[    5.740297] kernel: sof_sdw sof_sdw: ASoC: topology: could not load header: -22
[    5.740353] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: error: tplg component load failed -22
[    5.740362] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: error: failed to load DSP topology -22
[    5.740365] kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: ASoC: error at snd_soc_component_probe on 0000:00:1f.3: -22
[    5.740407] kernel: sof_sdw sof_sdw: ASoC: failed to instantiate card -22
[    5.740863] kernel: sof_sdw sof_sdw: error -EINVAL: snd_soc_register_card failed -22
[    5.740869] kernel: sof_sdw sof_sdw: probe with driver sof_sdw failed with error -22

Someone left the device in mockup mode?

kernel: snd_soc_sdw_utils:asoc_sdw_count_sdw_endpoints: sof_sdw sof_sdw: Found 3 devices with 3 endpoints
kernel: snd_soc_sdw_utils:asoc_sdw_parse_sdw_endpoints: sof_sdw sof_sdw: Adding prefix sdw_mockup_headset0 for sdw:0:0:0105:aa55:00
kernel: snd_soc_sdw_utils:asoc_sdw_parse_sdw_endpoints: sof_sdw sof_sdw: Add dev: 0, 0x105aa5500 end: 0, dai: 0, P/C to solo: 0
kernel: snd_soc_sdw_utils:asoc_sdw_parse_sdw_endpoints: sof_sdw sof_sdw: Adding prefix sdw_mockup_amp1 for sdw:0:1:0105:55aa:00
kernel: snd_soc_sdw_utils:asoc_sdw_parse_sdw_endpoints: sof_sdw sof_sdw: Add dev: 1, 0x100010555aa00 end: 0, dai: 1, P/C to solo: 0
kernel: snd_soc_sdw_utils:asoc_sdw_parse_sdw_endpoints: sof_sdw sof_sdw: Adding prefix sdw_mockup_mic3 for sdw:0:3:0105:5555:00
kernel: snd_soc_sdw_utils:asoc_sdw_parse_sdw_endpoints: sof_sdw sof_sdw: Add dev: 3, 0x3000105555500 end: 0, dai: 2, -/C to solo: 0
kernel: snd_soc_sof_sdw:sof_card_dai_links_create: sof_sdw sof_sdw: DAI link numbers: sdw 5, ssp 0, dmic 0, hdmi 3, bt: 0
kernel: File kernel/firmware/acpi/mockup-device-1amp.aml exceeding MAX_CPIO_FILE_NAME [18]
kernel: ACPI: SSDT ACPI table found in initrd [kernel/firmware/acpi/mockup-device-1am][0x99]

@kv2019i ?

ujfalusi avatar Feb 14 '25 12:02 ujfalusi

@ujfalusi That's my fault. I used jf-lnlm-rvp-sdw-1 to test SDW mockup mode yesterday. But I removed the mockup ADR from the acpi table already. Not sure why mockup devices are still present.

bardliao avatar Feb 14 '25 14:02 bardliao

The aml is not in the /lib/firmware/acpi-upgrades/ folder already.

ubuntu@jf-lnlm-rvp-sdw-1:~$ ls /lib/firmware/acpi-upgrades/
ubuntu@jf-lnlm-rvp-sdw-1:~$

I did it by the sudo ./acpi-rm command. Did I miss something?

bardliao avatar Feb 14 '25 14:02 bardliao

I have manually removed them, rebuilt the initramfs and rebooted the machine

ujfalusi avatar Feb 14 '25 14:02 ujfalusi

SOFCI TEST

ranj063 avatar Feb 14 '25 15:02 ranj063