linux icon indicating copy to clipboard operation
linux copied to clipboard

ASoC: SOF: ipc4-topology: Runtime module audio format print rework

Open ujfalusi opened this issue 1 year ago • 1 comments

Hi,

When the audio started we print out here and there the Input and Output or only the Input audio format for the module that is in path of the stream. This is mostly OK but provides inconsistent an - in my opinion - hard to grasp information.

The PR reworks how the input/output format is selected and tries to improve the consistency of the prints by applying universal rules:

  • Module is not changing the format or it has only input or output and it has single format on in and out side:
Audio format for gain.1.1:
  • Module is not changing the format or it has only input or output and it has multiple formats on either in or out side:
Audio format (in/out format index: 2/0) for host-copier.0.playback:
  • Module is changing format then we print the input and output ones:
  • Input if it has single format:
Input audio format for host-copier.0.capture:
  • Input has multiple formats:
Input audio format (format index: 0) for host-copier.0.playback:

Similar versions for the output format prints.

ujfalusi avatar May 23 '24 07:05 ujfalusi

Changes since v1:

  • drop patch to support (iow, handle) process modules with only outputs
  • Rework the common format printing function to be easier to read and firm rules to handle all possible permutations
  • Commit messages updated when requested.

ujfalusi avatar May 31 '24 09:05 ujfalusi

SOFCI TEST

plbossart avatar Jul 16 '24 08:07 plbossart

@bardliao can you take a look?

plbossart avatar Aug 06 '24 11:08 plbossart

@bardliao, @kv2019i, @ranj063, any objection to merge this PR?

ujfalusi avatar Sep 02 '24 10:09 ujfalusi

@bardliao, @kv2019i, @ranj063, any objection to merge this PR?

No, I was approved. :)

bardliao avatar Sep 02 '24 12:09 bardliao