linux icon indicating copy to clipboard operation
linux copied to clipboard

ASoC: SOF: Don't read reply if its not used

Open cujomalainey opened this issue 3 years ago • 10 comments

Most uses of the IPC TX reply only care about the return code which can be returned without passing a stack allocated struct. Let's save those copy cycles.

Signed-off-by: Curtis Malainey [email protected]

cujomalainey avatar Oct 14 '22 00:10 cujomalainey

I would be tempted to change the subject to "ASoC: SOF: ipc3: ..." as this change only affects IPC3 code path.

That isn't quite correct, the majority are, but there are changes in the compress code as well as the flood test.

cujomalainey avatar Oct 14 '22 14:10 cujomalainey

Found a couple more replies that could be removed and added them to the chain.

cujomalainey avatar Oct 14 '22 20:10 cujomalainey

Apologies for the rapid pushes, fixed a typo that then introduced a change-id

cujomalainey avatar Oct 14 '22 20:10 cujomalainey

quite a few build issues @cujomalainey

plbossart avatar Oct 26 '22 00:10 plbossart

quite a few build issues @cujomalainey

Yea saw that, sorry for the delay, was out sick Monday/Tuesday, trying to catch up

cujomalainey avatar Oct 28 '22 03:10 cujomalainey

Ah forgot the inline keyword. Will push a fix

cujomalainey avatar Nov 02 '22 00:11 cujomalainey

FYI I cannot open the checkpatch bot as I am getting SSL errors.

cujomalainey avatar Nov 02 '22 00:11 cujomalainey

@plbossart can we do a review? The longer the delay the likelyhood of more uses slipping in that the patches won't catch, my fix and rebase already caught 2 more.

cujomalainey avatar Nov 03 '22 21:11 cujomalainey

I'll be honest @cujomalainey, we have too many PRs in flight: https://github.com/thesofproject/linux/pull/3984 https://github.com/thesofproject/linux/pull/3888 https://github.com/thesofproject/linux/pull/3986 https://github.com/thesofproject/linux/pull/3933 https://github.com/thesofproject/linux/pull/3978 CI is undergoing a painful migration and a number of unfortunate regressions. And we have a number of really important PRs https://github.com/thesofproject/linux/pull/3972 https://github.com/thesofproject/linux/pull/3962 https://github.com/thesofproject/linux/pull/3953

Your PR makes complete sense but we have to be realistic on the urgency/priority. Thanks for your understanding.

plbossart avatar Nov 03 '22 22:11 plbossart

@plbossart understood, thanks for the update. Let me know when things calm down, I'll rebase to make sure I get any new cases then re-review.

cujomalainey avatar Nov 03 '22 22:11 cujomalainey

@plbossart just wanted to let you know I rebased these so if things have calmed down on your end they should be able to go in

cujomalainey avatar Nov 22 '22 22:11 cujomalainey

@iuliana-prodan It was more to keep the conceptually isolated since the first was produced on its own and is clean up, the other two are the prevention

cujomalainey avatar Nov 28 '22 23:11 cujomalainey

@ujfalusi @bardliao @ranj063 can you take a look at this PR please?

plbossart avatar Dec 02 '22 19:12 plbossart