ASoC: SOF: Don't read reply if its not used
Most uses of the IPC TX reply only care about the return code which can be returned without passing a stack allocated struct. Let's save those copy cycles.
Signed-off-by: Curtis Malainey [email protected]
I would be tempted to change the subject to "ASoC: SOF: ipc3: ..." as this change only affects IPC3 code path.
That isn't quite correct, the majority are, but there are changes in the compress code as well as the flood test.
Found a couple more replies that could be removed and added them to the chain.
Apologies for the rapid pushes, fixed a typo that then introduced a change-id
quite a few build issues @cujomalainey
quite a few build issues @cujomalainey
Yea saw that, sorry for the delay, was out sick Monday/Tuesday, trying to catch up
Ah forgot the inline keyword. Will push a fix
FYI I cannot open the checkpatch bot as I am getting SSL errors.
@plbossart can we do a review? The longer the delay the likelyhood of more uses slipping in that the patches won't catch, my fix and rebase already caught 2 more.
I'll be honest @cujomalainey, we have too many PRs in flight: https://github.com/thesofproject/linux/pull/3984 https://github.com/thesofproject/linux/pull/3888 https://github.com/thesofproject/linux/pull/3986 https://github.com/thesofproject/linux/pull/3933 https://github.com/thesofproject/linux/pull/3978 CI is undergoing a painful migration and a number of unfortunate regressions. And we have a number of really important PRs https://github.com/thesofproject/linux/pull/3972 https://github.com/thesofproject/linux/pull/3962 https://github.com/thesofproject/linux/pull/3953
Your PR makes complete sense but we have to be realistic on the urgency/priority. Thanks for your understanding.
@plbossart understood, thanks for the update. Let me know when things calm down, I'll rebase to make sure I get any new cases then re-review.
@plbossart just wanted to let you know I rebased these so if things have calmed down on your end they should be able to go in
@iuliana-prodan It was more to keep the conceptually isolated since the first was produced on its own and is clean up, the other two are the prevention
@ujfalusi @bardliao @ranj063 can you take a look at this PR please?