linux icon indicating copy to clipboard operation
linux copied to clipboard

ASoC: SOF: Intel: pci-tng: revert invalid bar size setting

Open plbossart opened this issue 3 years ago • 0 comments

The logic for the ioremap is to find the resource index 3 (IRAM) and infer the BAR address by subtracting the IRAM offset. The BAR size defined in hardware specifications is 2MB.

The commit 5947b2726beb6 ("ASoC: SOF: Intel: Check the bar size before remapping") tried to find the BAR size by querying the resource length instead of a pre-canned value, but by requesting the size for index 3 it only gets the size of the IRAM. That's obviously wrong and prevents the probe from proceeding.

This commit attempted to fix an issue in a fuzzing/simulated environment but created another on actual devices, so the best course of action is to revert that change.

Reported-by: Ferry Toth [email protected] BugLink: https://github.com/thesofproject/linux/issues/3901 Signed-off-by: Pierre-Louis Bossart [email protected]

plbossart avatar Oct 10 '22 15:10 plbossart