Better auto-indenting

[mhluongo]

Inserting a new-line in the middle of an arg list or event indents incorrectly for default linting rules in ethlint.

Similarly, when this snippet below is auto-formatted with = in visual mode...

for (uint i = 0; i < numTokens; i++) {
    uint256 idealBalance = D1.mul(balances0[i]).div(D0);
    uint256 difference = idealBalance.difference(balances1[i]);
    fees[i] = _fee.mul(difference).div(FEE_DENOMINATOR);
    balances[i] = balances1[i].sub(fees[i].mul(_adminFee).div(
        FEE_DENOMINATOR));
    balances1[i] = balances1[i].sub(fees[i]);
}

the indent yields

for (uint i = 0; i < numTokens; i++) {
    uint256 idealBalance = D1.mul(balances0[i]).div(D0);
    uint256 difference = idealBalance.difference(balances1[i]);
    fees[i] = _fee.mul(difference).div(FEE_DENOMINATOR);
    balances[i] = balances1[i].sub(fees[i].mul(_adminFee).div(
        FEE_DENOMINATOR));
        balances1[i] = balances1[i].sub(fees[i]);
}

Not ideal.

[fvictorio]

(Yet another unsolicited comment)

Have you tried prettier-solidity? It stills has some way to go, but it could really use the push of being used by a high profile project like tbtc. Formatting is a PITA (we removed styling rules in solhint for that reason), and I think it would be great if the community would move towards a unique formatting tool.

(This is my last bikeshedding, at least for today!)

[Shadowfiend]

I'm planning on slapping prettier-solidity onto all Keep and tBTC code in the extremely near future for both CI and precommit formatting, independently of Matt's work here :) I've already poked at it and despite any imperfections, it's a big boon.

[fvictorio]

@Shadowfiend glad to hear that! Feel free to open an issue for any imperfection you find, even bikeshedding is welcome :sweat_smile: