Sean Lee

Results 38 comments of Sean Lee

Note: Typescript 4.1 may introduce some option which may significantly reduce the issue and may render above consideration unnecessary. https://github.com/microsoft/TypeScript/issues/40124 - Investigate Preventing Global Conflicts with Strict Environment Configuration

Hi, finally the version which compiles with tensorflowjs is published. Please try with `@tscc/tscc` `0.6.0`! I've noticed that your repro repo https://github.com/MorganR/tensorflow-tscc contains an invalid closure compiler option `"target"`, you...

Thank you for your follow ups. I'm aware of the issue 2, I think it is something to be fixed from tsickle. Despite of this issue, as I understand closure...

Relevant issues: https://github.com/angular/tsickle/issues/1202, https://github.com/angular/tsickle/issues/1203

Most of existing d.ts files are _module_, not _script_ s. tsickle generate correct externs for _script_ d.ts files, but currently there are several bugs in tsickle regarding generation of externs...

https://github.com/google/closure-compiler/issues/1601#issuecomment-483452226 1. We could wait for the issue to be fixed (closure compiler implementing `@defines` without closure library) 2. or we could rewrite `@defines` to `goog.define` with ts transformer.

Hi, most likely the documentation on tinyMCE is assuming that you should be using `"esModuleInterop"` TS compiler flag. I suppose after you specify that flag, the `tsc` command will succeed....

Hi, first of all, your configuration looks good. It's just that `app.ts` file contains a single function that is called nowhere, so Closure Compiler is removing the function declaration and...

I suppose you can do something like this: ```jsonc { "external": { "path": "path" }, "compilerFlags": { "output_wrapper": "(function(path){%output%})(require('path'))" } } ```

As far as I know, tsickle does not support `esModuleInterop` flag. `tslib.__importDefault` is generated by this flag, so if you remove the `esModuleInterop` flag, it will compile well, I guess....