protoc-gen-ts icon indicating copy to clipboard operation
protoc-gen-ts copied to clipboard

Published 20 hours ago • verified publisher icon thesayyn

Support strip_import_prefix on proto_library rules

Open chris-codaio opened this issue 3 years ago • 1 comments

When using strip_import_prefix on a proto_library rule, then attempting to consume that proto output via ts_proto_library, I get back an error:

ERROR: /modules/protos/protos/BUILD:8:14: output 'modules/protos/protos/bazel-out/darwin-fastbuild/bin/_virtual_imports/my_proto/my_service.ts' was not created
ERROR: /modules/protos/protos/BUILD:8:14: Generating Protocol Buffers for Typescript //modules/protos/protos:my_service_proto failed: not all outputs were created or valid

chris-codaio avatar Jan 28 '22 23:01 chris-codaio

Ah, yes looks like we need special handling for _virtual_imports directory. do you mind sending a PR for this? with additional tests?

thesayyn avatar Jan 29 '22 19:01 thesayyn

Not relevant anymore as we don't have a bazel rule anymore

thesayyn avatar Nov 16 '23 01:11 thesayyn