Nadav Samet

Results 118 comments of Nadav Samet

It looks like there's no shutdown followed by awaitTermination on the client side similar to the change you recently made for the server side.

@ashwinbhaskar Currently there's a 0.6.0-test4 release. Help is still needed in debugging a flaky test so we can have a stable release.

Hi Dave, we're still publishing for 2.13, here are the artifacts: https://repo1.maven.org/maven2/com/thesamet/scalapb/zio-grpc/zio-grpc-core_2.13/0.4.3/ The codegen itself is published only for 2.12 since it's needed for sbt (which is based on 2.12),...

> In the ZIO/effect world of async, it could be more useful to start shutdown then return the result of io.grpc.ManagedChannel.awaitTermination using blocking effect. I agree. Will be open to...

> Could we amend this part of the code to only send headers if the call succeeds ? Thanks for bringing this up. Makes sense and PR would be welcome....

Yes, particularly asking for that since the doc status is marked as proposal that is ready to implementation. I wanted to be sure existing clients won't have issues with the...

Hey @Jacke , as I am not currently using mill myself, I will need your help here. Mill support for ScalaPB is based on ScalaPBC. Starting from the most recent...

Thank you! will review this week.

Hi @regiskuckaertz , let's create a seperate advanced client and use same-name methods. I can be convinced otherwise, but my rational for the choice is to keep interface for 99%...

Sorry for the delay. I'm out of town without desktop access until mid October. Overall looks good, though I'd like to take a closer look at the generated code. Can...