Sam James

Results 860 comments of Sam James

It's the same problem. It just shows up worse with LTO because Qt's sanity check can't fire to tell you (at the point where the preprocessor is run, the right...

Fedora, Debian/Ubuntu, opensuse, Alpine disable it. Arch disables it but only for Qt 5 AFAICT (has it enabled for Qt 6). Looks like Void has it on.

Interesting! It should happen since https://gitlab.archlinux.org/archlinux/packaging/packages/qt6-base/-/commit/5cd71aed56de955b182e20263a50cd91bf7b6aaa. Thiago gives some ways to check whether it was in effect at https://bugreports.qt.io/browse/QTBUG-112332?focusedId=716976&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-716976. I have an idea which may explain it, let me poke.

> This approach appears suitable for Gentoo's Qt packages as well [...] Yes, this is the conclusion I reached as well. The original Qt commit adding the improved version didn't...

Aggressively preferring snapshots can be an error if e.g. the next release becomes branched and someone doesn't notice or changes which aren't really necessary to have downstream end up backported...

With reluctance, I'll merge it with some fixups, but please investigate my comments.

https://github.com/gentoo/gentoo/pull/41095#issuecomment-2870251377

I just pushed a fix for the CI failure (unrelated to your PR), please rebase.

I just pushed a fix for the CI failure (unrelated to your PR), please rebase.